Skip to content

[7.x] TypeScript cleanup in visualizations plugin (#78428) | Implement tagcloud renderer (#77910) | Fix types (#78619)#78666

Merged
timroes merged 4 commits intoelastic:7.xfrom
timroes:backport/7.x/pr-78428_pr-77910_pr-78619
Sep 29, 2020
Merged

[7.x] TypeScript cleanup in visualizations plugin (#78428) | Implement tagcloud renderer (#77910) | Fix types (#78619)#78666
timroes merged 4 commits intoelastic:7.xfrom
timroes:backport/7.x/pr-78428_pr-77910_pr-78619

Conversation

@timroes
Copy link
Copy Markdown
Contributor

@timroes timroes commented Sep 28, 2020

Combined backport of the following commits to 7.x (to avoid the type conflicts between those PRs):

@timroes timroes added the backport This PR is a backport of another PR label Sep 28, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sulemanof and others added 3 commits September 28, 2020 21:09
* Implement toExpressionAst for tagcloud

* Implement tagcloud vis renderer

* Use resize observer

* Use common no data message

* Update build_pipeline.test

* Update tag cloud tests

* Revert "Use common no data message"

This reverts commit fddf019.

* Update interpreter functional tests

* Add tests for toExpressionAst fn

* Use throttled chart update

* Update renderer

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id value diff baseline
visTypeTagcloud 29 +3 26

async chunks size

id value diff baseline
visTypeTagcloud 295.4KB ⚠️ +295.4KB 0.0B

distributable file count

id value diff baseline
default 47545 +6 47539
oss 28255 +6 28249

page load bundle size

id value diff baseline
inputControlVis 154.1KB +4.0B 154.1KB
visTypeTable 78.0KB -13.0B 78.0KB
visTypeTagcloud 22.1KB -285.7KB 307.8KB
visualizations 272.7KB -867.0B 273.6KB
total -286.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@timroes timroes merged commit 1d48afc into elastic:7.x Sep 29, 2020
@timroes timroes deleted the backport/7.x/pr-78428_pr-77910_pr-78619 branch September 29, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants