Skip to content

[7.x] Add the @kbn/apm-config-loader package (#77855)#78585

Merged
pgayvallet merged 1 commit intoelastic:7.xfrom
pgayvallet:backport/7.x/pr-77855
Sep 28, 2020
Merged

[7.x] Add the @kbn/apm-config-loader package (#77855)#78585
pgayvallet merged 1 commit intoelastic:7.xfrom
pgayvallet:backport/7.x/pr-77855

Conversation

@pgayvallet
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* first shot of the apm configuration loader

* revert changes to kibana config

* remove test files for now

* remove `?.` usages

* use lazy config init to avoid crashing integration test runner

* loader improvements

* add config value override via cli args

* add tests for utils package

* add prod/dev config handling + loader tests

* add tests for config

* address josh's comments

* nit on doc
@pgayvallet pgayvallet added the backport This PR is a backport of another PR label Sep 28, 2020
@pgayvallet
Copy link
Copy Markdown
Contributor Author

retest

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id value diff baseline
enterpriseSearch 488.8KB +66.0B 488.7KB

page load bundle size

id value diff baseline
upgradeAssistant 64.3KB +33.0B 64.3KB

distributable file count

id value diff baseline
default 47381 +20 47361
oss 28095 +20 28075

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 9882afc into elastic:7.x Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants