Skip to content

[7.x] [Ingest Node Pipelines] New patterns component for Grok processor (#76533)#78434

Merged
jloleysens merged 1 commit intoelastic:7.xfrom
jloleysens:backport/7.x/pr-76533
Sep 24, 2020
Merged

[7.x] [Ingest Node Pipelines] New patterns component for Grok processor (#76533)#78434
jloleysens merged 1 commit intoelastic:7.xfrom
jloleysens:backport/7.x/pr-76533

Conversation

@jloleysens
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

…astic#76533)

* wip, issues with use fields getting cleared somehow

* New drag and drop text list component

- updated use array to add its own field so that we hook into form
- added new drag and drop list component
- wip on validation (empty lists validate immediately, which it should not)

* remove box shadow from editor fields

* Style grok patterns based on drag and drop in component templates

- still have the issue with validation
- need to get some design review at this point

* fix i18n

* update use_array - maintain the same API though

* Grok processor should use the new use array interface

- also fix the documentation using links in the processor type
  description. react was unhappy about hook order changing

* fix patterns field validation to check validity of pattern entires

* fix drag item styling

* fix use of form in use effect and update behaviour of submit button

* added smoke test for grok component

* fix i18n

* Implement PR feedback

* Implemented design feedback

- decreased spacing between list items and button
- fixed a11y issue between label and first text field
- moved help text to under label
- refactored all of the field layout logic into drag and drop
  text list component.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@jloleysens jloleysens added the backport This PR is a backport of another PR label Sep 24, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id value diff baseline
ingestPipelines 470 +19 451

async chunks size

id value diff baseline
ingestPipelines 785.6KB +16.2KB 769.3KB

page load bundle size

id value diff baseline
ingestPipelines 41.0KB +162.0B 40.9KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 0d01637 into elastic:7.x Sep 24, 2020
@jloleysens jloleysens deleted the backport/7.x/pr-76533 branch September 24, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants