Skip to content

[7.x] [Dev Tools] Call .destroy on ace when react component unmounts (#78132)#78150

Merged
jloleysens merged 1 commit intoelastic:7.xfrom
jloleysens:backport/7.x/pr-78132
Sep 22, 2020
Merged

[7.x] [Dev Tools] Call .destroy on ace when react component unmounts (#78132)#78150
jloleysens merged 1 commit intoelastic:7.xfrom
jloleysens:backport/7.x/pr-78132

Conversation

@jloleysens
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

@jloleysens jloleysens added the backport This PR is a backport of another PR label Sep 22, 2020
@jloleysens jloleysens changed the title [7.x] call .destroy on ace when react component unmounts (#78132) [7.x] [Dev Tools] Call .destroy on ace when react component unmounts (#78132) Sep 22, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
console 1.1MB +147.0B 1.1MB
searchprofiler 714.9KB +86.0B 714.8KB
total +233.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 949cb6a into elastic:7.x Sep 22, 2020
@jloleysens jloleysens deleted the backport/7.x/pr-78132 branch September 22, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants