[7.9] [Ingest Manager] Ensure at least default Error handling on all routes (#77975)#78088
Merged
jfsiii merged 3 commits intoelastic:7.9from Sep 22, 2020
jfsiii:backport/7.9/pr-77975
Merged
[7.9] [Ingest Manager] Ensure at least default Error handling on all routes (#77975)#78088jfsiii merged 3 commits intoelastic:7.9from jfsiii:backport/7.9/pr-77975
jfsiii merged 3 commits intoelastic:7.9from
jfsiii:backport/7.9/pr-77975
Conversation
…#77975) * res.customError -> defaultIngestErrorHandler * Missed a variable rename in prior commit * copying an invalid policy will 404; not 500 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/ingest_manager/server/routes/agent/acks_handlers.ts # x-pack/plugins/ingest_manager/server/routes/agent/handlers.ts # x-pack/plugins/ingest_manager/server/routes/agent_policy/handlers.ts # x-pack/plugins/ingest_manager/server/routes/package_policy/handlers.ts # x-pack/plugins/ingest_manager/server/routes/settings/index.ts # x-pack/test/ingest_manager_api_integration/apis/agent_policy/agent_policy.ts
Contributor
Author
|
More came in here than expected. I'll look more closely soon and fix |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.9: