[Lens] Use agg functions instead of string#77565
Closed
wylieconlon wants to merge 1 commit intoelastic:masterfrom
Closed
[Lens] Use agg functions instead of string#77565wylieconlon wants to merge 1 commit intoelastic:masterfrom
wylieconlon wants to merge 1 commit intoelastic:masterfrom
Conversation
Contributor
💔 Build Failed
Failed CI StepsTest FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/smokescreen·ts.lens app lens smokescreen tests should allow editing saved visualizationsStandard OutStack TraceChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/smokescreen·ts.lens app lens smokescreen tests should allow editing saved visualizationsStandard OutStack TraceChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard_mode/dashboard_empty_screen·js.dashboard mode empty dashboard adds Lens visualization to empty dashboardStandard OutStack TraceBuild metricspage load bundle size
To update your PR or re-run it, just comment with: |
Contributor
|
is this ready to review ? general approach looks ok. |
Contributor
Author
|
@ppisljar I don't think this is ready to review because at the time, it was causing errors on every Lens visualization. So it's not ready. Have you done any work on the esaggs function so that it can take non-JSON input? |
Contributor
|
its in progress, currently we are moving search source to the server and after that we plan to cleanup esaggs and move it to the server. |
Contributor
++ The plan was to update esaggs to use the agg functions when we move it to the server |
Contributor
Author
|
Closed in #84973 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does not work, but sets us up for the
esaggsfunction to be user-editableChecklist
Delete any items that are not applicable to this PR.
For maintainers