Skip to content

[7.x] [APM] Remove useLocation and some minor route improvements (#76343)#77476

Merged
smith merged 1 commit intoelastic:7.xfrom
smith:backport/7.x/pr-76343
Sep 15, 2020
Merged

[7.x] [APM] Remove useLocation and some minor route improvements (#76343)#77476
smith merged 1 commit intoelastic:7.xfrom
smith:backport/7.x/pr-76343

Conversation

@smith
Copy link
Copy Markdown
Contributor

@smith smith commented Sep 15, 2020

Backports the following commits to 7.x:

…6343)

* [APM] Remove useLocation and some minor route improvements

* Replace `useLocation` and our `LocationContext` with `useLocation` from React Router. We can do this since we're now using the platform history, added in elastic#76287.
* Pass in `RouteComponentProps` where appropriate to routes to use `history` and `location`.

This is in the service of elastic#51963, but doesn't do anything with `useUrlParams` or any of the other changes specified in that issue.
@smith smith added the backport This PR is a backport of another PR label Sep 15, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
apm 1255 -2 1257

async chunks size

id value diff baseline
apm 5.0MB -2.6KB 5.0MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 67c11fc into elastic:7.x Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants