Skip to content

[7.x] [ML] Account for "properties" layer in find_file_structure mappings (#77035)#77142

Merged
droberts195 merged 1 commit intoelastic:7.xfrom
droberts195:add_properties_to_find_file_structure_7x
Sep 10, 2020
Merged

[7.x] [ML] Account for "properties" layer in find_file_structure mappings (#77035)#77142
droberts195 merged 1 commit intoelastic:7.xfrom
droberts195:add_properties_to_find_file_structure_7x

Conversation

@droberts195
Copy link
Copy Markdown

Backports the following commits to 7.x:

…77035)

This is the UI side companion for elastic/elasticsearch#62158

Previously the "mappings" field of the response from the
find_file_structure endpoint was not a drop-in for the
mappings format of the create index endpoint - the
"properties" layer was missing. The reason for omitting
it initially was that the assumption was that the
find_file_structure endpoint would only ever return very
simple mappings without any nested objects. However,
this will not be true in the future, as we will improve
mappings detection for complex JSON objects. As a first
step it makes sense to move the returned mappings closer
to the standard format.
@droberts195 droberts195 added the backport This PR is a backport of another PR label Sep 10, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@droberts195 droberts195 merged commit a1b7deb into elastic:7.x Sep 10, 2020
@droberts195 droberts195 deleted the add_properties_to_find_file_structure_7x branch September 10, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants