Skip to content

[7.9] [Ingest Manager] Improve agent vs kibana version checks (#76238)#76490

Merged
jfsiii merged 1 commit intoelastic:7.9from
jfsiii:backport/7.9/pr-76238
Sep 3, 2020
Merged

[7.9] [Ingest Manager] Improve agent vs kibana version checks (#76238)#76490
jfsiii merged 1 commit intoelastic:7.9from
jfsiii:backport/7.9/pr-76238

Conversation

@jfsiii
Copy link
Copy Markdown
Contributor

@jfsiii jfsiii commented Sep 2, 2020

Backports the following commits to 7.9:

* Add logic spec'd in issue comments. Tests pass.

* Change fn to accept 1 (opt 2) string vs object

* Add tests based on issue comments

* Change expected error message in test

* Capitalize Kibana in error message

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@jfsiii jfsiii added backport This PR is a backport of another PR Team:Fleet Team label for Observability Data Collection Fleet team labels Sep 2, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii requested review from jen-huang, nchaulet and ph September 2, 2020 14:02
@jen-huang
Copy link
Copy Markdown
Contributor

@jfsiii Is there something specified you want reviewed for this backport and #76488 before merging? The code diffs look the same as original PR.

@jfsiii jfsiii merged commit 5beb515 into elastic:7.9 Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:Fleet Team label for Observability Data Collection Fleet team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants