Skip to content

[7.x] [Monaco] Refactor the way XJSON grammar checker gets registered (#75160)#75288

Merged
jloleysens merged 1 commit intoelastic:7.xfrom
jloleysens:backport/7.x/pr-75160
Aug 18, 2020
Merged

[7.x] [Monaco] Refactor the way XJSON grammar checker gets registered (#75160)#75288
jloleysens merged 1 commit intoelastic:7.xfrom
jloleysens:backport/7.x/pr-75160

Conversation

@jloleysens
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

…tic#75160)

* Refactor the way XJSON grammar checker gets registered

- avoid registering multiple model add listeners
- remove regsiterGrammarChecker from public API!
- fix getWorker handler to register XJSON only for XJSON models

* remove unused import

* updateAnnos -> updateAnnotations
@jloleysens jloleysens added the backport This PR is a backport of another PR label Aug 18, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ingestPipelines 643.4KB -116.0B 643.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 8ea2bb3 into elastic:7.x Aug 18, 2020
@jloleysens jloleysens deleted the backport/7.x/pr-75160 branch August 18, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants