Just realized it's not just the mapValues :) I'll go find the other lodash ones and update and then move out of draft.

@watson i realized i only did mapvalues and not all the other lodash ones. I've since updated and ran code mod to do them all!

Pinging @elastic/apm-ui (Team:apm)

Per this discussion on Slack, we're going to do this for the whole repo. I'll also work on adding the eslint rule above. Will be working on this this week!

I agree with @tylersmalley on this one. Although I'm not sure what will be the penalty impact of transform this at compile time, our lodash usage is really wide and I would prefer to have the code explicitly behave as expected. Another thing to consider is that in a future lodash major upgrade it would be easier to find the places with lodash usages we need to convert because we can just search for lodash/{function_name}. Finally, I'm not sure if the plugin is working as expected right now: lodash/babel-plugin-lodash#236. If we endup deciding to go through the transformation route, babel-plugin-transform-imports probably would be a better alternative as while it does not remap default imports it works as expected over named imports.

Nathan and I are doing this...

In summary, what we need to watch out for:

• Make sure no extra new lines are added
• Only edit in /public,/common, and /packages

to do:

• Revert to master
• write and run ESlint rule to get list of files
• do find import _, (\{ [a-zA-Z\s,]+ \}) from 'lodash' and replace with import $1 from 'lodash'
• run codemod on tht list of files
• fix spaces
• fix aliases
• turn back on prettier rules

@elasticmachine merge upstream

merge conflict between base and head

We're close! Just need to fetch the most recent and do this again to avoid conflicts.

• turn off prettier
• get list of files ( $yarn lint:es --format unix > output and then cat Output | cut -d ":" -f 1 > listOfFiles )
• run the codemod (jscodeshift --stdin --extensions=js,jsx,ts,tsx -t modular-lodash.js --parser=tsx < listOfFiles)
• run the regex to fix new line spaces (find: import(.*)lodash(.*)\n\nimport(.*) replace import$1lodash$2\nimport$3
• run the regex to fix aliases (git diff upstream/master | code - and search for import.*\sas\s.*lodash )
• turn prettier back on

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: 6c6b1cf
• Pipeline Steps (look for red circles / failed steps)
• Interpreting CI Failures

Failed CI Steps

• Check Types
• Check Doc API Changes
• Check Telemetry Schema
• Lint: eslint
• X-Pack Jest Unit Tests
• Execute xpack-kibana-ciGroup1
• Execute xpack-kibana-ciGroup1
• Execute xpack-kibana-ciGroup6
• Jest Unit Tests
• Execute xpack-kibana-ciGroup3

Test Failures

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Error: expect(received).toContain(expected) // indexOf

Expected value: "Remove the spaces from your index pattern."
Received array: []
    at Object.it (/dev/shm/workspace/parallel/10/kibana/x-pack/plugins/rollup/public/test/client_integration/job_create_logistics.test.js:98:42)

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Error: expect(received).toContain(expected) // indexOf

Expected value: "Index pattern doesn't match any indices."
Received array: []
    at Object.it (/dev/shm/workspace/parallel/10/kibana/x-pack/plugins/rollup/public/test/client_integration/job_create_logistics.test.js:105:42)

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Error: expect(received).toContain(expected) // indexOf

Expected value: "Index pattern must match indices that contain time fields."
Received array: []
    at Object.it (/dev/shm/workspace/parallel/10/kibana/x-pack/plugins/rollup/public/test/client_integration/job_create_logistics.test.js:112:42)

and 83 more failures, only showing the first 3.

Build metrics

@kbn/optimizer bundle module count

async chunks size

page load bundle size

History

• 💔 Build #70030 failed e620a163676577f55ba7d35f937a97ea11a1108c
• 💔 Build #67375 failed 57b963e031de10f28657f224bfe9b7013783beac
• 💚 Build #66968 succeeded 6f8250c7d5cd9779146ba006d01080bf41e9c0a2
• 💚 Build #66935 succeeded fbdae3fa444b19f35edcb40e309c5bdc7ecc300c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

is this PR old and should be closed? 7.9.2 FF is today... also this doesn't seem like it should go into a patch release. Going to remove the label!

is this PR old and should be closed? 7.9.2 FF is today... also this doesn't seem like it should go into a patch release. Going to remove the label!

Thanks for removing the label. It's still in progress but it's a big hairy change.

Closing in favor of #78156.