Prevents reporting font update from triggering restart#74029
Prevents reporting font update from triggering restart#74029tylersmalley wants to merge 1 commit intoelastic:masterfrom
Conversation
This file appears to be touched regularly on Linux (WSL2) triggering a server restart. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
I get the same issue and have heard other devs say the same thing.
I have tried searching around in the repo to find a reference to this file that would explain it, but I have not come up with an answer. @tylersmalley I assume you've tried the same thing. I don't see anything wrong with the file attributes either. |
|
I find that dev server startup works fine even after: Could it be something about the file itself which confuses nodemon (or whatever we use for dev)? |
|
I did a test using
In my test, there are no changes. I'm not sure why the dev server detects something is happening |
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
|
In src/cli/cluster/cluster_manager.ts, the When I log The ClusterManager class has an FSWatcher as What if we just add an early return in |
If we go with that solution, unfortunately that would have a breaking change to no longer cause a server restart if a file is added in the repo. A Draft PR is here: #74141 @elastic/kibana-operations any idea why the optimizer thinks this font file was added to the repo shortly after it begins watching for changes? |
|
@tylersmalley this PR is no longer applicable. I solved the issue of the font file triggering restart by making the path to the file shorter (less depth). |
This file appears to be touched regularly on Linux (WSL2) triggering a server restart.
@elastic/kibana-reporting-services, any idea why this is happening?