Skip to content

[7.x] [ML] Migrate to React BrowserRouter and Kibana provided History. (#71941)#73919

Merged
walterra merged 1 commit intoelastic:7.xfrom
walterra:backport/7.x/pr-71941
Jul 31, 2020
Merged

[7.x] [ML] Migrate to React BrowserRouter and Kibana provided History. (#71941)#73919
walterra merged 1 commit intoelastic:7.xfrom
walterra:backport/7.x/pr-71941

Conversation

@walterra
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

…stic#71941)

- Migrate to React BrowserRouter and Kibana provided History including a fallback to redirect legacy hash based URLs.
- Migrate breadcrumbs away from hash based URLs.
- Make sure relative custom urls still work after migration.
@walterra walterra added the backport This PR is a backport of another PR label Jul 31, 2020
@walterra walterra self-assigned this Jul 31, 2020
@walterra walterra added the :ml label Jul 31, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
ml 1225 +1 1224

page load bundle size

id value diff baseline
ml 4.3MB +9.8KB 4.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@walterra walterra merged commit 8c488ac into elastic:7.x Jul 31, 2020
@walterra walterra deleted the backport/7.x/pr-71941 branch July 31, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR :ml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants