[grunt] Task to rebuild archives with new version#7225
Merged
epixa merged 1 commit intoelastic:masterfrom May 18, 2016
Merged
Conversation
This is useful for when a pre-release build is completely tested and could be released as-is if it weren't for the pre-release suffix and commit hash. It will extract the archives in the target, replace the version, sha, and build numbers with the current working copy's, and then recreate the archives and shas.
Contributor
|
example: |
Contributor
|
LGTM |
| import { join } from 'path'; | ||
|
|
||
| export default (grunt) => { | ||
| grunt.registerTask('_rebuild:createArchives', function () { |
Contributor
There was a problem hiding this comment.
would it make sense to reuse _build:archives instead?
Contributor
Author
There was a problem hiding this comment.
I originally tried to go down that route, but it would have required pretty fundamental changes to _build:archives, so I decided against it. Basically, _build:archives assumes that all platforms are present in the build directory (something not guaranteed in a rebuild) and that all builds have the same version as the current working copy's package.json (something not true if you're using the buildversion argument).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for when a pre-release build is completely tested and
could be released as-is if it weren't for the pre-release suffix and
commit hash. It will extract the archives in the target, replace the
version, sha, and build numbers with the current working copy's, and
then recreate the archives and shas.