Skip to content

[7.x] [Security Solution][Detections] Disable exceptions for Threshold and ML rules (#72137)#72217

Merged
rylnd merged 1 commit intoelastic:7.xfrom
rylnd:backport/7.x/pr-72137
Jul 17, 2020
Merged

[7.x] [Security Solution][Detections] Disable exceptions for Threshold and ML rules (#72137)#72217
rylnd merged 1 commit intoelastic:7.xfrom
rylnd:backport/7.x/pr-72137

Conversation

@rylnd
Copy link
Copy Markdown
Contributor

@rylnd rylnd commented Jul 17, 2020

Backports the following commits to 7.x:

…ML rules (elastic#72137)

* Move isThresholdRule predicate into our common folder

This is very similar to isMlRule, which is already used extensively and
lives at this level.

* Disable endpoint association checkbox for ML and Threshold rules

The fullWidth and isDisabled props were not used; what we want is
disabled.

* Fix react warning about nesting buttons

This removes the AdvancedSettingsAccordion in favor of a plain
EuiAccordion with buttonContent, as that seems to be all that's needed
here.

* Disable Exceptions tab on Details for ML or Threshold rules

These rule types do not currently support exceptions.

* Fix type error

Unused import
@rylnd rylnd added the backport This PR is a backport of another PR label Jul 17, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB -97.0B 7.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd merged commit b590bc2 into elastic:7.x Jul 17, 2020
@rylnd rylnd deleted the backport/7.x/pr-72137 branch July 17, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants