Closed
Conversation
…ownstream projects
We need declaration: true to use incremental builds. But when generating declaration files new TS errors show up. This commit fixes errors like: Exported variable 'expressionsPluginMock' has or is using name 'MockedElasticSearchServiceSetup' from external module "/Users/rudolf/dev/kibana/src/core/server/elasticsearch/elasticsearch_service.mock" but cannot be named.
7 tasks
Contributor
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/management/_create_index_pattern_wizard·js.management "Create Index Pattern" wizard data streams can be an index patternStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/management/_create_index_pattern_wizard·js.management "Create Index Pattern" wizard data streams can be an index patternStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_filter_bar·js.dashboard app using current data dashboard filter bar filter editor field list shows index pattern of vis when one is addedStandard OutStack TraceBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
Contributor
|
With TS v4 very close I think we should close this in favor of #72280. If we start to run into issues that are going to significantly slow down our 4.0 upgrade, we can reconsider going with this route. But otherwise, doing in this 4.0 requires a lot fewer changes to enable incremental builds (due to not having to emit any declaration files). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Typescript project references and incremental builds to speed up performance. I've been fairly aggressive in either excluding typechecking or adding
anyto get the typechecker to work. I hope to get to fully working project references first and then pulling in teams to see if they can help solve the remaining type errors in a more elegant way.Status
Checklist
Delete any items that are not applicable to this PR.
For maintainers