Skip to content

[7.x] [APM] Service maps anomaly detection integration by environment (#70932)#71391

Merged
ogupte merged 3 commits intoelastic:7.xfrom
ogupte:backport/7.x/pr-70932
Jul 13, 2020
Merged

[7.x] [APM] Service maps anomaly detection integration by environment (#70932)#71391
ogupte merged 3 commits intoelastic:7.xfrom
ogupte:backport/7.x/pr-70932

Conversation

@ogupte
Copy link
Copy Markdown
Contributor

@ogupte ogupte commented Jul 11, 2020

Backports the following commits to 7.x:

…tic#70932)

* Closes elastic#69480 & elastic#70419.
- Adds anomaly detection integration to service maps backed by apm ML jobs per environment
- Loads transaction stats and anomalies for each transaction types
- Renders a selector in the popop to choose a transaction type to view stats

* - implements original anomaly detection integration design for service maps popover
- only aggregates transaction KPIs and anomaly scores for transaction.type = "request" or "page-load"
- supports environment filter 'All' option to display data from all APM anomaly detection jobs
- handle case where popover metrics don't exist for services outside the current environment filter

* fixes some CI errors

* Simplified messaging for service popop with not data in the current environment

* PR feedback, renamed max anomalies -> service anomalies including the file name

* - defines custom_settings.job_tags.apm_ml_version in ML job creation,
  then filters for it when returing valid APM ML jobs

* changes shape of of service anomalies from an array to a object keyed by serviceName

* removes the url encoding from ML job link href to how it was previously.

* PR feedback

* Popover no data state simplified:
- renders the "no data" message as plain text instead of in a callout
- hides the 'Anomaly detection' section if there is not anomaly data.

* Fixes filtering bug when user selects 'Environment: Not defined'. Now
filters properly by filtering for docs where service.environment does
not exist

* filters jobs fetched in the settings page by `job.custom_settings.job_tags.apm_ml_version`

* Fixed bad import from last upstream merge

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@ogupte ogupte added the backport This PR is a backport of another PR label Jul 11, 2020
@ogupte
Copy link
Copy Markdown
Contributor Author

ogupte commented Jul 11, 2020

@elasticmachine merge upstream

@ogupte
Copy link
Copy Markdown
Contributor Author

ogupte commented Jul 12, 2020

retest

@ogupte
Copy link
Copy Markdown
Contributor Author

ogupte commented Jul 12, 2020

@elasticmachine merge upstream

@ogupte
Copy link
Copy Markdown
Contributor Author

ogupte commented Jul 12, 2020

retest

@ogupte
Copy link
Copy Markdown
Contributor Author

ogupte commented Jul 13, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ogupte ogupte merged commit 28c5d91 into elastic:7.x Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants