Skip to content

[SIEM][Detection Engine][Lists] Adds "wait_for" to all the create, update, patch, delete endpoints#71262

Merged
FrankHassanabad merged 1 commit intoelastic:masterfrom
FrankHassanabad:add-wait-for
Jul 9, 2020
Merged

[SIEM][Detection Engine][Lists] Adds "wait_for" to all the create, update, patch, delete endpoints#71262
FrankHassanabad merged 1 commit intoelastic:masterfrom
FrankHassanabad:add-wait-for

Conversation

@FrankHassanabad
Copy link
Copy Markdown
Contributor

@FrankHassanabad FrankHassanabad commented Jul 9, 2020 •
edited
Loading

Summary

  • Adds "wait_for" to all the create, update, patch, and delete endpoints
  • Ran some quick tests against import and the performance still looks acceptable
  • Updates the unit tests to reflect the addition

Checklist

@FrankHassanabad FrankHassanabad requested review from a team as code owners July 9, 2020 15:38
@FrankHassanabad FrankHassanabad self-assigned this Jul 9, 2020
@FrankHassanabad FrankHassanabad added v9.0.0 v7.9.0 release_note:skip Skip the PR/issue when compiling release notes Team:SIEM labels Jul 9, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 9, 2020

Pinging @elastic/siem (Team:SIEM)

rylnd
rylnd approved these changes Jul 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's
Get
This
Merged
👍

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 9, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@FrankHassanabad FrankHassanabad merged commit 4b4796d into elastic:master Jul 9, 2020
@FrankHassanabad FrankHassanabad deleted the add-wait-for branch July 9, 2020 18:33
@FrankHassanabad FrankHassanabad mentioned this pull request Jul 9, 2020
Merged
@rylnd rylnd mentioned this pull request Jul 14, 2020
Merged
12 tasks
@nkhristinin nkhristinin mentioned this pull request Sep 10, 2021
Merged
2 tasks
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 23, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

@jbudz jbudz added backport:skip This PR does not require backporting and removed v9.0.0 labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rylnd rylnd rylnd approved these changes

Assignees

@FrankHassanabad FrankHassanabad

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@FrankHassanabad @elasticmachine @kibanamachine @rylnd @MindyRS @jbudz