[Styles] Update Generic Add Data wizard styling and layout#7013
Merged
Bargs merged 1 commit intoelastic:feature/ingestfrom Apr 26, 2016
Merged
[Styles] Update Generic Add Data wizard styling and layout#7013Bargs merged 1 commit intoelastic:feature/ingestfrom
Bargs merged 1 commit intoelastic:feature/ingestfrom
Conversation
This was referenced Apr 21, 2016
|
|
||
| .wizard-step-headings{ | ||
| margin-top: 1em; | ||
| padding-top: 1em; |
Contributor
There was a problem hiding this comment.
It looks like our code base uses the px unit for things like padding and margin, with a few exceptions. I spoke with @panda01 and he suggested we continue to use px for these styles, and only use em for font sizes.
Contributor
|
bounced back because of small style comment |
Contributor
|
jenkins, test it |
Contributor
|
LGTM. Once the build passes... |
161218b to
422d906
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes 3 changes: