Fix #6813 - Create dynamic links to filebeat documentation#6989
Merged
Bargs merged 4 commits intoelastic:feature/ingestfrom May 3, 2016
Merged
Fix #6813 - Create dynamic links to filebeat documentation#6989Bargs merged 4 commits intoelastic:feature/ingestfrom
Bargs merged 4 commits intoelastic:feature/ingestfrom
Conversation
Contributor
Author
|
@clintongormley could you confirm if my implementation here will be testable for you, per our conversation in #6813? |
Contributor
|
@Bargs sorry for the delay - this LGTM |
Contributor
Author
|
No worries @clintongormley, thanks for taking a look! |
Contributor
|
@Bargs If this is good w/ clint its good for me |
Contributor
|
@Bargs ping me when you merge this into master/5.0 - i've got a patch ready to go |
This was referenced May 9, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6813
This PR makes 2 changes:
documentation_linksmodule to provide a home for all dynamically versioned links to docs in Kibana.