Skip to content

[7.x] Explore underlying data (#68496)#69367

Merged
streamich merged 1 commit intoelastic:7.xfrom
streamich:backport/7.x/pr-68496
Jun 17, 2020
Merged

[7.x] Explore underlying data (#68496)#69367
streamich merged 1 commit intoelastic:7.xfrom
streamich:backport/7.x/pr-68496

Conversation

@streamich
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* feat: 🎸 stub discover_enhanced plugin

* feat: 🎸 improve view in discover action

* feat: 🎸 add URL generator to "View in Discover" action

* feat: 🎸 implement navigation and getHref in view raw logs actio

* fix: 🐛 disable action in "edit" mode

* refactor: 💡 renamce context menu view in discover action

* feat: 🎸 rename action to "explore data"

* fix: 🐛 correctly generate action path

* feat: 🎸 add internationalization to "explore action"

* fix: 🐛 correctly parse generated Discover URL path

* test: 💍 setup basic functional tests

* refactor: 💡 modularize url generation logic

* feat: 🎸 export CommonlyUsed type

* test: 💍 add test subjects to panel custom time range modal

* test: 💍 add index patterna and time range functional tests

* refactor: 💡 rename action file

* refactor: 💡 use URL generator from Discover plugin's contract

* test: 💍 add "Explore raw data" action unit tests

* fix: 🐛 import share plugin to check if it is enabled

* Update x-pack/plugins/discover_enhanced/public/actions/view_in_discover/explore_data_context_menu_action.ts

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

* chore: 🤖 add discover_enhanced to KibanaApp codeowners

* test: 💍 improve "Explore underlying data" functional tests

* test: 💍 improve <a> link assertion

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
# Conflicts:
#	.github/CODEOWNERS
@streamich streamich added the backport This PR is a backport of another PR label Jun 17, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
discoverEnhanced 2 +2 -

page load asset size

beta
id value diff baseline
/bundles/plugin/discoverEnhanced/discoverEnhanced.plugin.js 13.8KB +13.8KB -
/bundles/plugin/uiActionsEnhanced/uiActionsEnhanced.plugin.js 85.0KB +215.0B 84.8KB
total - +14.0KB -

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit cab833e into elastic:7.x Jun 17, 2020
@streamich streamich deleted the backport/7.x/pr-68496 branch June 17, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants