Skip to content

[7.x] [SIEM][Exceptions] - ExceptionsViewer cleanup (#68739)#68815

Merged
yctercero merged 1 commit intoelastic:7.xfrom
yctercero:backport/7.x/pr-68739
Jun 10, 2020
Merged

[7.x] [SIEM][Exceptions] - ExceptionsViewer cleanup (#68739)#68815
yctercero merged 1 commit intoelastic:7.xfrom
yctercero:backport/7.x/pr-68739

Conversation

@yctercero
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

### Summary

- Adds missing unit tests for relevant files missing them
- Changes filter search to fire request on 'Enter'
- Breaks out the main ExceptionViewer component into smaller components to make more readable and better tested
- Updates utility bar to have the specific list description text next to it as proposed by @spong in elastic#68294 (comment)
- Adds loading state any time async request occurs
- Now fetches list on list type toggle (if user selects to view either only detections or endpoint items), before was simply filtering already fetched items
@yctercero yctercero added the backport This PR is a backport of another PR label Jun 10, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit e2e0a14 into elastic:7.x Jun 10, 2020
@yctercero yctercero deleted the backport/7.x/pr-68739 branch October 14, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants