Skip to content

[7.7] only block registration when appRoute contains the exact basePath (#67125)#68090

Merged
pgayvallet merged 1 commit intoelastic:7.7from
pgayvallet:backport/7.7/pr-67125
Jun 3, 2020
Merged

[7.7] only block registration when appRoute contains the exact basePath (#67125)#68090
pgayvallet merged 1 commit intoelastic:7.7from
pgayvallet:backport/7.7/pr-67125

Conversation

@pgayvallet
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.7:

@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_listing·js.dashboard app using legacy data dashboard listing page search does not match mid word

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/60721

[00:00:00]       │
[00:00:00]         └-: dashboard app
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: using legacy data
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> "before all" hook: loadLogstash
[00:00:00]               │ info [logstash_functional] Loading "mappings.json"
[00:00:00]               │ info [logstash_functional] Loading "data.json.gz"
[00:00:00]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:00]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.22][0]]]).
[00:00:00]               │ info [logstash_functional] Created index "logstash-2015.09.22"
[00:00:00]               │ debg [logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:00]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:00]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.20][0]]]).
[00:00:00]               │ info [logstash_functional] Created index "logstash-2015.09.20"
[00:00:00]               │ debg [logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:00]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:00]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.21][0]]]).
[00:00:00]               │ info [logstash_functional] Created index "logstash-2015.09.21"
[00:00:00]               │ debg [logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:10]               │ info progress: 9025
[00:00:13]               │ info [logstash_functional] Indexed 4633 docs into "logstash-2015.09.22"
[00:00:13]               │ info [logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:00:13]               │ info [logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:04:33]             └-: dashboard listing page
[00:04:33]               └-> "before all" hook
[00:04:33]               └-> "before all" hook
[00:04:33]                 │ debg load kibana index with visualizations and log data
[00:04:33]                 │ info [dashboard/legacy] Loading "mappings.json"
[00:04:33]                 │ info [dashboard/legacy] Loading "data.json.gz"
[00:04:33]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [.kibana_2/ALhvpck1SXyCcrxxn6t0BA] deleting index
[00:04:33]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [.kibana_1/xNcYB9kcSMarAhfZzA72_Q] deleting index
[00:04:33]                 │ info [dashboard/legacy] Deleted existing index [".kibana_2",".kibana_1"]
[00:04:33]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:04:33]                 │ info [dashboard/legacy] Created index ".kibana"
[00:04:33]                 │ debg [dashboard/legacy] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:04:33]                 │ info [dashboard/legacy] Indexed 9 docs into ".kibana"
[00:04:33]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [.kibana/4vA5RVuNT2eIgiXhyOqxLw] update_mapping [_doc]
[00:04:33]                 │ debg Migrating saved objects
[00:04:33]                 │ proc [kibana]   log   [14:44:46.751] [info][savedobjects-service] Creating index .kibana_2.
[00:04:33]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:04:33]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] updating number_of_replicas to [0] for indices [.kibana_2]
[00:04:33]                 │ proc [kibana]   log   [14:44:46.830] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:04:33]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:04:33]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] updating number_of_replicas to [0] for indices [.kibana_1]
[00:04:34]                 │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] 1868 finished with response BulkByScrollResponse[took=25.6ms,timed_out=false,sliceId=null,updated=0,created=9,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:04:34]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [.kibana/4vA5RVuNT2eIgiXhyOqxLw] deleting index
[00:04:34]                 │ proc [kibana]   log   [14:44:47.189] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:04:34]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [.kibana_2/r-xqgEuESOmx113O04Kp1Q] update_mapping [_doc]
[00:04:34]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [.kibana_2/r-xqgEuESOmx113O04Kp1Q] update_mapping [_doc]
[00:04:34]                 │ proc [kibana]   log   [14:44:47.290] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:04:34]                 │ proc [kibana]   log   [14:44:47.357] [info][savedobjects-service] Finished in 609ms.
[00:04:34]                 │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:04:34]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [.kibana_2/r-xqgEuESOmx113O04Kp1Q] update_mapping [_doc]
[00:04:36]                 │ debg replacing kibana config doc: {"defaultIndex":"logstash-*"}
[00:04:36]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1591193906099070355] [.kibana_2/r-xqgEuESOmx113O04Kp1Q] update_mapping [_doc]
[00:04:37]                 │ debg navigating to dashboard url: http://localhost:6151/app/kibana#/dashboards
[00:04:37]                 │ debg navigate to: http://localhost:6151/app/kibana#/dashboards
[00:04:37]                 │ debg ... sleep(700) start
[00:04:37]                 │ debg browser[INFO] http://localhost:6151/app/kibana?_t=1591195489896#/dashboards 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:37]                 │
[00:04:37]                 │ debg browser[INFO] http://localhost:6151/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:37]                 │ debg ... sleep(700) end
[00:04:37]                 │ debg returned from get, calling refresh
[00:04:38]                 │ debg browser[INFO] http://localhost:6151/app/kibana?_t=1591195489896#/dashboards 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:38]                 │
[00:04:38]                 │ debg browser[INFO] http://localhost:6151/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:38]                 │ debg currentUrl = http://localhost:6151/app/kibana#/dashboards
[00:04:38]                 │          appUrl = http://localhost:6151/app/kibana#/dashboards
[00:04:38]                 │ debg TestSubjects.find(kibanaChrome)
[00:04:38]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:04:40]                 │ debg TestSubjects.find(kibanaChrome)
[00:04:40]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:04:40]                 │ debg browser[INFO] http://localhost:6151/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106452 "INFO: 2020-06-03T14:44:52Z
[00:04:40]                 │        Adding connection to http://localhost:6151/elasticsearch
[00:04:40]                 │
[00:04:40]                 │      "
[00:04:40]                 │ debg ... sleep(501) start
[00:04:41]                 │ debg ... sleep(501) end
[00:04:41]                 │ debg in navigateTo url = http://localhost:6151/app/kibana#/dashboards?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:04:41]                 │ debg TestSubjects.exists(statusPageContainer)
[00:04:41]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:04:43]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:05:48]               └-: search
[00:05:48]                 └-> "before all" hook
[00:05:48]                 └-> "before all" hook
[00:05:48]                   │ debg Find.allByCssSelector('.euiFieldSearch') with timeout=10000
[00:05:48]                   │ debg TestSubjects.exists(newItemButton)
[00:05:48]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="newItemButton"]') with timeout=2500
[00:05:48]                   │ debg TestSubjects.click(newItemButton)
[00:05:48]                   │ debg Find.clickByCssSelector('[data-test-subj="newItemButton"]') with timeout=10000
[00:05:48]                   │ debg Find.findByCssSelector('[data-test-subj="newItemButton"]') with timeout=10000
[00:05:48]                   │ debg TestSubjects.click(dashboardSaveMenuItem)
[00:05:48]                   │ debg Find.clickByCssSelector('[data-test-subj="dashboardSaveMenuItem"]') with timeout=10000
[00:05:48]                   │ debg Find.findByCssSelector('[data-test-subj="dashboardSaveMenuItem"]') with timeout=10000
[00:05:48]                   │ debg TestSubjects.find(savedObjectSaveModal)
[00:05:48]                   │ debg Find.findByCssSelector('[data-test-subj="savedObjectSaveModal"]') with timeout=10000
[00:05:48]                   │ debg entering new title
[00:05:48]                   │ debg TestSubjects.setValue(savedObjectTitle, Two Words)
[00:05:48]                   │ debg TestSubjects.click(savedObjectTitle)
[00:05:48]                   │ debg Find.clickByCssSelector('[data-test-subj="savedObjectTitle"]') with timeout=10000
[00:05:48]                   │ debg Find.findByCssSelector('[data-test-subj="savedObjectTitle"]') with timeout=10000
[00:05:48]                   │ debg DashboardPage.clickSave
[00:05:48]                   │ debg TestSubjects.click(confirmSaveSavedObjectButton)
[00:05:48]                   │ debg Find.clickByCssSelector('[data-test-subj="confirmSaveSavedObjectButton"]') with timeout=10000
[00:05:48]                   │ debg Find.findByCssSelector('[data-test-subj="confirmSaveSavedObjectButton"]') with timeout=10000
[00:05:48]                   │ debg Find.waitForElementStale with timeout=10000
[00:05:49]                   │ debg TestSubjects.exists(saveDashboardSuccess)
[00:05:49]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="saveDashboardSuccess"]') with timeout=120000
[00:05:49]                   │ debg Find.findByCssSelector('.euiToast') with timeout=20000
[00:05:49]                   │ debg Find.findByCssSelector('.euiToastHeader__title') with timeout=10000
[00:05:49]                   │ debg Toast title: Dashboard 'Two Words' was saved
[00:05:49]                   │ debg Find.clickByCssSelector('.euiToast__closeButton') with timeout=10000
[00:05:49]                   │ debg Find.findByCssSelector('.euiToast__closeButton') with timeout=10000
[00:05:49]                   │ debg isGlobalLoadingIndicatorVisible
[00:05:49]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[00:05:49]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:05:51]                   │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:05:51]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:05:51]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:05:51]                   │ debg Waiting for save modal to close
[00:05:51]                   │ debg TestSubjects.exists(savedObjectSaveModal)
[00:05:51]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="savedObjectSaveModal"]') with timeout=2500
[00:05:54]                   │ debg --- retry.tryForTime error: [data-test-subj="savedObjectSaveModal"] is not displayed
[00:05:54]                   │ debg gotoDashboardLandingPage
[00:05:54]                   │ debg onDashboardLandingPage
[00:05:54]                   │ debg TestSubjects.exists(dashboardLandingPage)
[00:05:54]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=5000
[00:05:57]                   │ debg --- retry.tryForTime error: [data-test-subj="dashboardLandingPage"] is not displayed
[00:06:00]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:01]                   │ debg clickDashboardBreadcrumbLink
[00:06:01]                   │ debg Find.clickByCssSelector('a[href="#/dashboards"]') with timeout=10000
[00:06:01]                   │ debg Find.findByCssSelector('a[href="#/dashboards"]') with timeout=10000
[00:06:01]                   │ debg expectExistsDashboardLandingPage
[00:06:01]                   │ debg TestSubjects.exists(dashboardLandingPage)
[00:06:01]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=120000
[00:06:01]                 └-> matches on the first word
[00:06:01]                   └-> "before each" hook: global before each
[00:06:01]                   │ debg searchForItemWithName: Two
[00:06:01]                   │ debg Find.allByCssSelector('.euiFieldSearch') with timeout=10000
[00:06:01]                   │ debg isGlobalLoadingIndicatorVisible
[00:06:01]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[00:06:01]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:06:03]                   │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:06:03]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:06:03]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:06:03]                   │ debg Find.allByCssSelector('[data-test-subj^="dashboardListingTitleLink"]') with timeout=10000
[00:06:03]                   └- ✓ pass  (2.5s) "dashboard app using legacy data dashboard listing page search matches on the first word"
[00:06:03]                 └-> matches the second word
[00:06:03]                   └-> "before each" hook: global before each
[00:06:03]                   │ debg searchForItemWithName: Words
[00:06:03]                   │ debg Find.allByCssSelector('.euiFieldSearch') with timeout=10000
[00:06:03]                   │ debg isGlobalLoadingIndicatorVisible
[00:06:03]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[00:06:03]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:06:04]                   │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:06:06]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:06]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:06:06]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:06:06]                   │ debg Find.allByCssSelector('[data-test-subj^="dashboardListingTitleLink"]') with timeout=10000
[00:06:06]                   └- ✓ pass  (3.1s) "dashboard app using legacy data dashboard listing page search matches the second word"
[00:06:06]                 └-> matches the second word prefix
[00:06:06]                   └-> "before each" hook: global before each
[00:06:06]                   │ debg searchForItemWithName: Wor
[00:06:06]                   │ debg Find.allByCssSelector('.euiFieldSearch') with timeout=10000
[00:06:07]                   │ debg isGlobalLoadingIndicatorVisible
[00:06:07]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[00:06:07]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:06:07]                   │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:06:09]                   │ debg --- retry.tryForTime failed again with the same message...
[00:06:09]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:06:09]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:06:09]                   │ debg Find.allByCssSelector('[data-test-subj^="dashboardListingTitleLink"]') with timeout=10000
[00:06:09]                   └- ✓ pass  (3.0s) "dashboard app using legacy data dashboard listing page search matches the second word prefix"
[00:06:09]                 └-> does not match mid word
[00:06:09]                   └-> "before each" hook: global before each
[00:06:09]                   │ debg searchForItemWithName: ords
[00:06:09]                   │ debg Find.allByCssSelector('.euiFieldSearch') with timeout=10000
[00:06:10]                   │ debg isGlobalLoadingIndicatorVisible
[00:06:10]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[00:06:10]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:06:10]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:06:10]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:06:10]                   │ debg Find.allByCssSelector('[data-test-subj^="dashboardListingTitleLink"]') with timeout=10000
[00:06:10]                   │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/dashboard app using legacy data dashboard listing page search does not match mid word.png"
[00:06:10]                   │ info Current URL is: http://localhost:6151/app/kibana#/dashboards?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:06:10]                   │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/dashboard app using legacy data dashboard listing page search does not match mid word.html
[00:06:10]                   └- ✖ fail: "dashboard app using legacy data dashboard listing page search does not match mid word"
[00:06:10]                   │

Stack Trace

Error: expected 1 to equal 0
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.equal (packages/kbn-expect/expect.js:227:8)
    at Context.<anonymous> (test/functional/apps/dashboard/dashboard_listing.js:131:38)
    at process._tickCallback (internal/process/next_tick.js:68:7)

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 01b2909 into elastic:7.7 Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants