Skip to content

[7.x] [build] Removes commonjs transforms (#66506)#67375

Merged
spalger merged 12 commits intoelastic:7.xfrom
tylersmalley:backport/7.x/pr-66506
Jun 4, 2020
Merged

[7.x] [build] Removes commonjs transforms (#66506)#67375
spalger merged 12 commits intoelastic:7.xfrom
tylersmalley:backport/7.x/pr-66506

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley commented May 26, 2020

Backports the following commits to 7.x:

@tylersmalley @spalger @elasticmachine
[build] Removes commonjs transforms (elastic#66506)
880779a 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	packages/kbn-optimizer/src/integration_tests/basic_optimization.test.ts
#	src/optimize/base_optimizer.js
#	src/optimize/create_ui_exports_module.js
@tylersmalley tylersmalley added the backport This PR is a backport of another PR label May 26, 2020
@tylersmalley
Copy link
Copy Markdown
Member Author

tylersmalley commented May 26, 2020

@elasticmachine merge upstream

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Jun 1, 2020

@elasticmachine merge upstream

@spalger spalger self-assigned this Jun 1, 2020
@spalger
Copy link
Copy Markdown
Contributor

spalger commented Jun 2, 2020

@joshdover this PR was delayed because it required a number of changes to support legacy apps that don't seem to be in master. Do you think I should be putting these changes into master as well? For instance: https://github.com/elastic/kibana/pull/67375/files#diff-4ba6d07c93612f4694318c0e0b442785L177-R178 and the related mocks needed to be updated to use const { default: chrome } because chrome is the default export of ui/chrome... So I'm assuming that legacyAppRegister() doesn't actually work in master but there aren't any failing tests... Thoughts?

@joshdover
Copy link
Copy Markdown
Contributor

joshdover commented Jun 2, 2020

@joshdover this PR was delayed because it required a number of changes to support legacy apps that don't seem to be in master. Do you think I should be putting these changes into master as well? For instance: https://github.com/elastic/kibana/pull/67375/files#diff-4ba6d07c93612f4694318c0e0b442785L177-R178 and the related mocks needed to be updated to use const { default: chrome } because chrome is the default export of ui/chrome... So I'm assuming that legacyAppRegister() doesn't actually work in master but there aren't any failing tests... Thoughts?

So we will still be shipping one legacy app in 7.9, the deprecated Timelion app (it's behind a config flag). Unfortunately there are no e2e tests for this app. This app will be migrated soon but not in 7.9

@joshdover
Copy link
Copy Markdown
Contributor

joshdover commented Jun 2, 2020

That said, I can't imagine needing these fixes in master. But we do need them in 7.x right now.

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Jun 2, 2020

@elasticmachine merge upstream

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Jun 3, 2020

@elasticmachine merge upstream

@ogupte
Copy link
Copy Markdown
Contributor

ogupte commented Jun 4, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 4, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Jun 4, 2020

Thanks @ogupte!

@spalger spalger merged commit 22c539f into elastic:7.x Jun 4, 2020
@spalger spalger deleted the backport/7.x/pr-66506 branch June 4, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@spalger spalger

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tylersmalley @spalger @joshdover @ogupte @kibanamachine @elasticmachine