[console] kbn top nav customizations#6721
Merged
spalger merged 4 commits intoelastic:masterfrom Apr 1, 2016
Merged
Conversation
171b334 to
b6784df
Compare
b6784df to
af8f2d9
Compare
| hasFunction: !!opt.run, | ||
| description: ('Toggle ' + opt.key), | ||
| noButton: !!opt.noButton, | ||
| openByDefault: !!opt.openByDefault , |
Contributor
There was a problem hiding this comment.
I'm not a fan of this, why can't you just call kbnTopNav.open()? It seems this shouldn't really be this directives responsibility.
Contributor
Author
There was a problem hiding this comment.
How am I supposed to get access to kbnTopNav? It's only accessible within the scope of the kbn-top-nav element.
Contributor
There was a problem hiding this comment.
Discussed on irc, but it is available to the scope.
https://github.com/elastic/kibana/pull/6657/files#diff-5616a348aebd0b4a63f32be784d7432cR96
Contributor
|
Sexiness. LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to use the kbnTopNav in console I needed it to:
.'s in themTo do accomplish this:
noButtonoptions for the config items_.get()to read the config from scope