[7.x] [Index management] Add support in url for hidden toggle (#66715)#67166
Merged
jloleysens merged 1 commit intoelastic:7.xfrom May 22, 2020
Merged
[7.x] [Index management] Add support in url for hidden toggle (#66715)#67166jloleysens merged 1 commit intoelastic:7.xfrom
jloleysens merged 1 commit intoelastic:7.xfrom
Conversation
* First iteration of supporting hidden indices in indices table Tests probably have broken * Remove unused code * Fix logic when calling get index endpoint with empty array Also remove unused translations * First iteration of new flag being passed in through URL * Added includeHidden param to index management list view This allows setting the value of the "inlcude hidden" toggle via the url hash query param "includeHidden". Also added a test. * Remove unused variable * Revise data flow The component toggle gets it's initial state form hash query param and thereafter the toggle drives the state in the url. * Fix typo * Delete ts-ignore * Slight update to test and comment placement for clarity * Fix copy-pasta Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: