Skip to content

Fix fix/config pull issues#6711

Closed
rashidkpc wants to merge 12 commits intoelastic:masterfrom
rashidkpc:pulltweaks/6657
Closed

Fix fix/config pull issues#6711
rashidkpc wants to merge 12 commits intoelastic:masterfrom
rashidkpc:pulltweaks/6657

Conversation

@rashidkpc
Copy link
Copy Markdown
Contributor

@rashidkpc rashidkpc commented Mar 30, 2016

This is basically the same as #6657, buy with linting fixed and the couple other bugs that @w33ble and i found taken care of.

panda01 and others added 12 commits March 24, 2016 15:34
@panda01
[Config] Modified the config objects to be able to access the whole s…
466d3ad 
…cope, and be a bit more transparent, also some code cleanup
@panda01
Merge remote-tracking branch 'upstream/master' into fix/configObject
9979aa1
@panda01
[TopNavbar] Made a new directive to reduce overhead when making a men…
0c420c2 
…u in your app
@panda01
[TopNavBar] Expanded the scope of top navbar to also help with drawin…
dc35fc4 
…g extensions, added top navbar to every page
@panda01
Merge remote-tracking branch 'upstream/master' into fix/configObject
3203d05
@panda01
[kbnTopNav] adding back the timepicker
5678d4d
@panda01
[Tests] Fixing tests
35f17d6
@panda01
[Tests] Fixing tests and also some code cleanup
26cceb8
Merge branch 'pr/6657' into kable
076fe1a
Merge remote-tracking branch 'upstream/master' into kable
226151e
Fix linting, replace 'add' in dashboard nav, fix add vis button, remo…
fba30d4 
…ve timepicker opening button
Remove need for config= in view
c4c2298
@rashidkpc
Copy link
Copy Markdown
Contributor Author

rashidkpc commented Mar 30, 2016

Test failures are totally valid:

Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive incorrect use should throw if missing a name property FAILED
    expected fn to throw an exception
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.throwException@http://localhost:5610/bundles/tests.bundle.js:235720:1
    @http://localhost:5610/bundles/tests.bundle.js:260046:1

Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive incorrect use should throw if missing a button group FAILED
    expected fn to throw an exception
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.throwException@http://localhost:5610/bundles/tests.bundle.js:235720:1
    @http://localhost:5610/bundles/tests.bundle.js:260053:1

Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive incorrect use should throw if multiple button groups FAILED
    expected fn to throw an exception
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.throwException@http://localhost:5610/bundles/tests.bundle.js:235720:1
    @http://localhost:5610/bundles/tests.bundle.js:260060:1

Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive incorrect use should throw if button group not direct child FAILED
    expected fn to throw an exception
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.throwException@http://localhost:5610/bundles/tests.bundle.js:235720:1
    @http://localhost:5610/bundles/tests.bundle.js:260067:1

.
Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive injecting extensions should append to end then order == 0 FAILED
    expected 3 to equal 4
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.equal@http://localhost:5610/bundles/tests.bundle.js:235765:1
    @http://localhost:5610/bundles/tests.bundle.js:260096:9

Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive injecting extensions should append to end then order > 0 FAILED
    expected 3 to equal 4
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.equal@http://localhost:5610/bundles/tests.bundle.js:235765:1
    @http://localhost:5610/bundles/tests.bundle.js:260104:9

Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive injecting extensions should append to end then order < 0 FAILED
    expected 3 to equal 4
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.equal@http://localhost:5610/bundles/tests.bundle.js:235765:1
    @http://localhost:5610/bundles/tests.bundle.js:260112:9

@rashidkpc rashidkpc mentioned this pull request Mar 30, 2016
Merged
@w33ble
Copy link
Copy Markdown
Contributor

w33ble commented Mar 30, 2016

All those tests are related to the navbar injection, which doesn't work the same way anymore.

The test cases should probably be translated to the kbn-top-nav or navbar-extensions directive though, as it should work the same there.

EDIT: I think you really just need to check the kbn-top-nav throws if it doesn't have a name attribute. All the tests around the button group checks aren't valid anymore.

@rashidkpc rashidkpc changed the title Pulltweaks/6657 Fix fix/config pull issues Mar 30, 2016
@rashidkpc
Copy link
Copy Markdown
Contributor Author

rashidkpc commented Mar 31, 2016

Closing in place of #6657

@rashidkpc rashidkpc closed this Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

blocker v5.0.0-alpha1 v5.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rashidkpc @w33ble @epixa @panda01