Fixes #6698 - ES no longer supports unmapped_type param on _score field sorting#6707
Merged
Bargs merged 1 commit intoelastic:masterfrom Mar 31, 2016
Merged
Fixes #6698 - ES no longer supports unmapped_type param on _score field sorting#6707Bargs merged 1 commit intoelastic:masterfrom
Bargs merged 1 commit intoelastic:masterfrom
Conversation
…ore field sorting
Contributor
|
jenkins, test it |
Contributor
|
LGTM |
Contributor
|
This LGTM, however I'm having trouble reproducing this issue with kibana and es master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6698
A simple fix to remove the unmapped_type option if sorting on the _score field now that Elasticsearch no longer supports it: elastic/elasticsearch#17392 (comment)
Upon review, normalizeSortRequest seemed like a natural place to put something like this since it already contains special logic to handle different kinds of fields (e.g. scripted fields).