Conversation
--------- **Commit 1:** [courier/segmentedRequest] mark the request "started" synchronously * Original sha: 8a49926 * Authored by spalger <spalger@users.noreply.github.com> on 2016-03-24T21:35:00Z **Commit 2:** [courier/fetch] detect aborted requests more agressively * Original sha: c12f18d * Authored by spalger <spalger@users.noreply.github.com> on 2016-03-24T21:35:46Z **Commit 3:** [courier/callClient] if there are no executable requests, do nothing * Original sha: 8fef03b * Authored by spalger <spalger@users.noreply.github.com> on 2016-03-24T21:36:18Z **Commit 4:** [courier/tests] updated test * Original sha: 985f997 * Authored by spalger <spalger@users.noreply.github.com> on 2016-03-24T22:25:31Z
b4a31b9 to
6ac2c36
Compare
Contributor
|
@spalger Can you review this? I basically had to apply the backport by hand since courier differs so much between master and 4.x. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #6651
Commit 1:
[courier/segmentedRequest] mark the request "started" synchronously
Commit 2:
[courier/fetch] detect aborted requests more agressively
Commit 3:
[courier/callClient] if there are no executable requests, do nothing
Commit 4:
[courier/tests] updated test