[filterbar] Only warn about non-filterable field when it's actually being filtered by#6582
Merged
rashidkpc merged 2 commits intoelastic:masterfrom Mar 25, 2016
Merged
[filterbar] Only warn about non-filterable field when it's actually being filtered by#6582rashidkpc merged 2 commits intoelastic:masterfrom
rashidkpc merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
This LGTM, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6573
The vis legend currently simulates clicking adding a filter to the filter bar in order to tell if the field is filterable. When the field is not filterable it would add a warning to the notifier, which wasn't helpful (because the user hadn't actually tried to filter by it) and because the check for if something is filterable was being done in a watcher, causing an infinite digest loop.
To prevent this the warning is only logged when the event is not being simulated.