[7.8] [ML] Fix pagination reset on search query update. (#65668)#65815
Merged
walterra merged 2 commits intoelastic:7.8from May 8, 2020
Merged
[7.8] [ML] Fix pagination reset on search query update. (#65668)#65815walterra merged 2 commits intoelastic:7.8from
walterra merged 2 commits intoelastic:7.8from
Conversation
Fixes pagination issue: When the query bar query changes, we need to check the selected page is still valid. Example: If you're on a last page (125), edit the filter, and it looks like the grid is trying to reload page 125 even though there are only 24 pages for the new query value you end up with an empty table. This brings over a fix already in place for the transform data grids: On every search query change we'll reset the pagination index.
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.8: