Skip to content

[7.x] [Alerting] changes preconfigured actions config from array to object (#65397)#65756

Merged
pmuellr merged 1 commit intoelastic:7.xfrom
pmuellr:backport/7.x/pr-65397
May 7, 2020
Merged

[7.x] [Alerting] changes preconfigured actions config from array to object (#65397)#65756
pmuellr merged 1 commit intoelastic:7.xfrom
pmuellr:backport/7.x/pr-65397

Conversation

@pmuellr
Copy link
Copy Markdown
Contributor

@pmuellr pmuellr commented May 7, 2020

Backports the following commits to 7.x:

…lastic#65397)

resolves elastic#63171

Previously, preconfigured actions were specified as an array of action
properties.  This ended up being problematic when using the kibana keystore
for secrets, as you'd have to reference specific actions via index.

This changes preconfigured actions to be specified as an object, where the
property key is the id, and the body is the remainder of the action properties.

As access to preconfigured actions has leaked across the code base, it's
probably time to consider changing the internal representation from an array
to a Map, to provide easier access by action id.  For a future PR.
@pmuellr pmuellr added the backport This PR is a backport of another PR label May 7, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pmuellr pmuellr merged commit ddb3e6d into elastic:7.x May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants