[7.x] [NP][Discover] Move discover into new platform (#63473)#65177
Merged
sulemanof merged 3 commits intoelastic:7.xfrom May 6, 2020
Merged
[7.x] [NP][Discover] Move discover into new platform (#63473)#65177sulemanof merged 3 commits intoelastic:7.xfrom
sulemanof merged 3 commits intoelastic:7.xfrom
Conversation
* Move discover into NP * Convert doc_table tests to jest * Move rows_headers to use jest * Move fixed_scroll.test * Clean up * Revert jest changes * Pass down deps into IndexPatternFieldList * Fix conflicts * Pass env vars * Remove LegacyCoreStart * Update generated doc * Fix canvas type * Fix i18n * Improve stub_index_pattern code * Add fieldFormats to mocked services * Skip failing tests - while still working on them, to find out if other tests fail in jenkins * Unskip sidebar test * Move mocha tests to legacy - delete jest tests, can be converted later on * Fix Scss imports - Seems functional tests didn't build because of them? * Remove another invalid SCSS import * Pass deps as last argument * Move field list into data start contract * Move create field into data start contract, fix tests * Update docs * Fix duplicating fields * Update snapshots in management * Fix review comments * Update docs * Fix angular compilation * Update docs Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # .github/CODEOWNERS # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
# Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.field._constructor_.md # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.field.md # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md # src/legacy/ui/public/field_editor/field_editor.test.tsx # src/plugins/data/public/index.ts # src/plugins/data/public/public.api.md # x-pack/legacy/plugins/canvas/canvas_plugin_src/expression_types/embeddable_types.ts
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: