[binder] share binder code with ui and server#6507
Merged
spalger merged 5 commits intoelastic:masterfrom Mar 25, 2016
Merged
Conversation
This breaks the ui/Binder class into two, a base class that is shared beteween server and ui/Binder, then a subclass which is now exposed as ui/Binder. This subclass adds the jQuery and d3 specific binding methods, as well as the ability to autp-destroy using a $scope
src/utils/binder.js
Outdated
| @@ -0,0 +1,21 @@ | |||
| import { bindKey, rest } from 'lodash'; | |||
Contributor
There was a problem hiding this comment.
Neither of these are used any longer.
Contributor
|
Just a few small things. |
Contributor
Author
|
Thanks, fixed identified issues. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks the
ui/Binderclass into two, a base class that is shared between server andui/Binder, then a subclass which is now exposed asui/Binder. The subclass adds thejQueryandd3specific binding methods, as well as the ability to auto-destroy using a$scope.