Skip to content

[7.x] [Maps] do not display EMS or kibana layer wizards when not configured (#64554)#64827

Merged
nreese merged 1 commit intoelastic:7.xfrom
nreese:backport/7.x/pr-64554
Apr 29, 2020
Merged

[7.x] [Maps] do not display EMS or kibana layer wizards when not configured (#64554)#64827
nreese merged 1 commit intoelastic:7.xfrom
nreese:backport/7.x/pr-64554

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Apr 29, 2020

Backports the following commits to 7.x:

…elastic#64554)

* [Maps] do not display EMS or kibana layer wizards when not configured

* default tilemap to empty object instead of array

* fix typo

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@nreese nreese added the backport This PR is a backport of another PR label Apr 29, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / Plugin Functional Tests.x-pack/test/plugin_api_integration/test_suites/event_log/public_api_integration·ts.event_log Event Log public API should support pagination for events

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/64812

[00:00:00]       │
[00:00:00]         └-: event_log
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: Event Log public API
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> should allow querying for events by Saved Object
[00:00:00]               └-> "before each" hook: global before each
[00:00:00]               │ debg Logging Event for Saved Object ca42b8ed-4b22-49a3-8eac-6215a92ebfe3
[00:00:00]               │ proc [kibana]   log   [20:41:16.304] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: ca42b8ed-4b22-49a3-8eac-6215a92ebfe3 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ca42b8ed-4b22-49a3-8eac-6215a92ebfe3"}]},"message":"test 2020-04-29T20:41:16.222Z"}
[00:00:00]               │ proc [kibana]   log   [20:41:16.343] [info][eventLogFixture][event_log_fixture][plugins][plugins] log event error: Error: Saved object [event_log_test/ca42b8ed-4b22-49a3-8eac-6215a92ebfe3] not found
[00:00:00]               │ proc [kibana]   log   [20:41:16.999] [info][eventLogFixture][event_log_fixture][plugins][plugins] created saved object
[00:00:00]               │ proc [kibana]   log   [20:41:17.001] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:00]               │ debg Logging Event for Saved Object ca42b8ed-4b22-49a3-8eac-6215a92ebfe3
[00:00:00]               │ proc [kibana]   log   [20:41:17.003] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ca42b8ed-4b22-49a3-8eac-6215a92ebfe3"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T20:41:16.222Z","@timestamp":"2020-04-29T20:41:17.000Z","ecs":{"version":"1.5.0"}}
[00:00:00]               │ proc [kibana]   log   [20:41:17.100] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: ca42b8ed-4b22-49a3-8eac-6215a92ebfe3 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ca42b8ed-4b22-49a3-8eac-6215a92ebfe3"}]},"message":"test 2020-04-29T20:41:16.223Z"}
[00:00:00]               │ proc [kibana]   log   [20:41:17.146] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:00]               │ proc [kibana]   log   [20:41:17.147] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:00]               │ debg calling /api/event_log/event_log_test/ca42b8ed-4b22-49a3-8eac-6215a92ebfe3/_find
[00:00:00]               │ proc [kibana]   log   [20:41:17.149] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"ca42b8ed-4b22-49a3-8eac-6215a92ebfe3"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T20:41:16.223Z","@timestamp":"2020-04-29T20:41:17.146Z","ecs":{"version":"1.5.0"}}
[00:00:01]               │ debg --- retry.try error: expected 0 to equal 2
[00:00:01]               │ debg calling /api/event_log/event_log_test/ca42b8ed-4b22-49a3-8eac-6215a92ebfe3/_find
[00:00:01]               └- ✓ pass  (1.7s) "event_log Event Log public API should allow querying for events by Saved Object"
[00:00:01]             └-> should support pagination for events
[00:00:01]               └-> "before each" hook: global before each
[00:00:01]               │ debg Logging Event for Saved Object 6eaf4766-0c4b-40f1-a75a-37a5e65dc80c
[00:00:01]               │ proc [kibana]   log   [20:41:18.082] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 6eaf4766-0c4b-40f1-a75a-37a5e65dc80c {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}]},"message":"test 2020-04-29T20:41:17.935Z"}
[00:00:01]               │ proc [kibana]   log   [20:41:18.117] [info][eventLogFixture][event_log_fixture][plugins][plugins] log event error: Error: Saved object [event_log_test/6eaf4766-0c4b-40f1-a75a-37a5e65dc80c] not found
[00:00:02]               │ proc [kibana]   log   [20:41:19.018] [info][eventLogFixture][event_log_fixture][plugins][plugins] created saved object
[00:00:02]               │ proc [kibana]   log   [20:41:19.019] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:02]               │ debg Logging Event for Saved Object 6eaf4766-0c4b-40f1-a75a-37a5e65dc80c
[00:00:02]               │ debg Logging Event for Saved Object 6eaf4766-0c4b-40f1-a75a-37a5e65dc80c
[00:00:02]               │ debg Logging Event for Saved Object 6eaf4766-0c4b-40f1-a75a-37a5e65dc80c
[00:00:02]               │ debg Logging Event for Saved Object 6eaf4766-0c4b-40f1-a75a-37a5e65dc80c
[00:00:02]               │ debg Logging Event for Saved Object 6eaf4766-0c4b-40f1-a75a-37a5e65dc80c
[00:00:02]               │ proc [kibana]   log   [20:41:19.021] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T20:41:17.935Z","@timestamp":"2020-04-29T20:41:19.018Z","ecs":{"version":"1.5.0"}}
[00:00:02]               │ proc [kibana]   log   [20:41:19.190] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 6eaf4766-0c4b-40f1-a75a-37a5e65dc80c {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}]},"message":"test 2020-04-29T20:41:17.935Z"}
[00:00:02]               │ proc [kibana]   log   [20:41:19.198] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 6eaf4766-0c4b-40f1-a75a-37a5e65dc80c {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}]},"message":"test 2020-04-29T20:41:17.935Z"}
[00:00:02]               │ proc [kibana]   log   [20:41:19.208] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 6eaf4766-0c4b-40f1-a75a-37a5e65dc80c {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}]},"message":"test 2020-04-29T20:41:17.936Z"}
[00:00:03]               │ proc [kibana]   log   [20:41:19.218] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 6eaf4766-0c4b-40f1-a75a-37a5e65dc80c {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}]},"message":"test 2020-04-29T20:41:17.935Z"}
[00:00:03]               │ proc [kibana]   log   [20:41:19.242] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 6eaf4766-0c4b-40f1-a75a-37a5e65dc80c {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}]},"message":"test 2020-04-29T20:41:17.936Z"}
[00:00:03]               │ proc [kibana]   log   [20:41:19.244] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:03]               │ proc [kibana]   log   [20:41:19.245] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:03]               │ proc [kibana]   log   [20:41:19.247] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:03]               │ proc [kibana]   log   [20:41:19.248] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:03]               │ proc [kibana]   log   [20:41:19.249] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T20:41:17.935Z","@timestamp":"2020-04-29T20:41:19.244Z","ecs":{"version":"1.5.0"}}
[00:00:03]               │ proc [kibana]   log   [20:41:19.250] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T20:41:17.935Z","@timestamp":"2020-04-29T20:41:19.247Z","ecs":{"version":"1.5.0"}}
[00:00:03]               │ proc [kibana]   log   [20:41:19.255] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:03]               │ proc [kibana]   log   [20:41:19.256] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:03]               │ proc [kibana]   log   [20:41:19.258] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T20:41:17.936Z","@timestamp":"2020-04-29T20:41:19.255Z","ecs":{"version":"1.5.0"}}
[00:00:03]               │ proc [kibana]   log   [20:41:19.260] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:03]               │ proc [kibana]   log   [20:41:19.261] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:03]               │ proc [kibana]   log   [20:41:19.264] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T20:41:17.935Z","@timestamp":"2020-04-29T20:41:19.260Z","ecs":{"version":"1.5.0"}}
[00:00:03]               │ proc [kibana]   log   [20:41:19.268] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:03]               │ proc [kibana]   log   [20:41:19.269] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:03]               │ debg calling /api/event_log/event_log_test/6eaf4766-0c4b-40f1-a75a-37a5e65dc80c/_find
[00:00:03]               │ proc [kibana]   log   [20:41:19.271] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T20:41:17.936Z","@timestamp":"2020-04-29T20:41:19.268Z","ecs":{"version":"1.5.0"}}
[00:00:03]               │ debg --- retry.try error: expected 0 to equal 6
[00:00:03]               │ debg calling /api/event_log/event_log_test/6eaf4766-0c4b-40f1-a75a-37a5e65dc80c/_find
[00:00:03]               │ debg calling /api/event_log/event_log_test/6eaf4766-0c4b-40f1-a75a-37a5e65dc80c/_find?per_page=3
[00:00:03]               │ debg calling /api/event_log/event_log_test/6eaf4766-0c4b-40f1-a75a-37a5e65dc80c/_find?per_page=3&page=2
[00:00:03]               │ debg failed to match {"foundEvents":[{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T20:41:17.936Z","@timestamp":"2020-04-29T20:41:19.255Z","ecs":{"version":"1.5.0"}},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T20:41:17.935Z","@timestamp":"2020-04-29T20:41:19.260Z","ecs":{"version":"1.5.0"}},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T20:41:17.936Z","@timestamp":"2020-04-29T20:41:19.268Z","ecs":{"version":"1.5.0"}}],"expectedEvents":[{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}]},"message":"test 2020-04-29T20:41:17.935Z"},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}]},"message":"test 2020-04-29T20:41:17.936Z"},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"6eaf4766-0c4b-40f1-a75a-37a5e65dc80c"}]},"message":"test 2020-04-29T20:41:17.936Z"}]}
[00:00:03]               └- ✖ fail: "event_log Event Log public API should support pagination for events"
[00:00:03]               │

Stack Trace

{ Error: expected 'test 2020-04-29T20:41:17.936Z' to sort of equal 'test 2020-04-29T20:41:17.935Z'
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at forEach (test/plugin_api_integration/test_suites/event_log/public_api_integration.ts:179:40)
    at Array.forEach (<anonymous>)
    at assertEventsFromApiMatchCreatedEvents (test/plugin_api_integration/test_suites/event_log/public_api_integration.ts:176:19)
    at Context.it (test/plugin_api_integration/test_suites/event_log/public_api_integration.ts:77:7)
  actual: 'test 2020-04-29T20:41:17.936Z',
  expected: 'test 2020-04-29T20:41:17.935Z',
  showDiff: true }

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 3ed2f11 into elastic:7.x Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants