Skip to content

[7.x] use cache busting for KP bundles (#64414)#64816

Merged
spalger merged 1 commit intoelastic:7.xfrom
spalger:backport/7.x/pr-64414
Apr 29, 2020
Merged

[7.x] use cache busting for KP bundles (#64414)#64816
spalger merged 1 commit intoelastic:7.xfrom
spalger:backport/7.x/pr-64414

Conversation

@spalger
Copy link
Copy Markdown
Contributor

@spalger spalger commented Apr 29, 2020

Backports the following commits to 7.x:

* convert into TS

* load plugin scripts in html body

* use buildNum as a unique Id for cache busting

* add tests for caching

* fix tests

* remove the last TODO. url should be inlined with assetss server

* this logic handled by publicPathMap on the client

* cache kbn-shared-deps as well

* attempt to fix karma tests

* always run file through replace stream

* place buildHash at begining of path, include all static files

* update bundles_route tests to inject buildNum everywhere

* fix karma config to point to right prefix

* use isDist naming throughout

* explain magic number with variables

* restore replacePublicPath option from elastic#64226

* replace one more instance of replacePublicPath

* use promisify instead of bluebird + non-null assertions

* remove one more magic number

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@spalger spalger added the backport This PR is a backport of another PR label Apr 29, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 73ae576 into elastic:7.x Apr 29, 2020
@spalger spalger deleted the backport/7.x/pr-64414 branch April 29, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants