[Ingest pipelines] Component integration tests#64489
Closed
alisonelizabeth wants to merge 11 commits intoelastic:feature/ingest-node-pipelinesfrom
Closed
[Ingest pipelines] Component integration tests#64489alisonelizabeth wants to merge 11 commits intoelastic:feature/ingest-node-pipelinesfrom
alisonelizabeth wants to merge 11 commits intoelastic:feature/ingest-node-pipelinesfrom
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
51fea6d to
5a32235
Compare
…bana into ingest_pipelines/tests
Contributor
Author
|
/cc @cuff-links |
b3c6db5 to
641ff6c
Compare
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
merge conflict between base and head |
…bana into ingest_pipelines/tests
…bana into ingest_pipelines/tests
Contributor
Author
|
retest |
1 similar comment
Contributor
Author
|
retest |
…bana into ingest_pipelines/tests
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
@alisonelizabeth Reviewing this. I ran them locally and they run fine. We are looking to get more passes before merging though. Need this ran 50 times in a row and passing. |
Contributor
|
@alisonelizabeth I am going to run it. Will link back here. |
Contributor
Author
|
Since the feature branch has been merged to master, closing this PR in favor of #65316. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds component integration tests for the Ingest Node Pipelines UI.
The tests are not yet exhaustive; in particular, there is room for better coverage around the "test pipeline" functionality. However, I believe it does provide a good foundation and covers all the main components. I will open a separate PR to add any additional tests.