Update string field mappings to text/keyword#6411
Update string field mappings to text/keyword#6411Bargs wants to merge 5 commits intoelastic:masterfrom
Conversation
There was a problem hiding this comment.
Note these mapping changes are going to break for anyone upgrading from an existing Kibana 4.x installation in which they have not saved at least one of each type of saved object. Eg, if they've saved visualizations and dashboards but never saved a search, saving a search will fail.
|
Tests are passing, so this is available if it's decided that we should move everything from string to text/keyword. |
|
Marking this as blocked until we sort out the gameplan here. |
|
For now Elasticsearch has put support for |
|
How should we proceed with this PR, then? |
|
We need to hold on this PR until we get the reindex stuff in |
07baa1a to
552cd41
Compare
|
This can't go in until we build in a capability to reindex and version the kibana index, so I'm going to close it for now. We can continue to track the issue here #6404 |
|
I don't think we should conflate the two. #6404 is a blocker for this, but it should be done without also introducing all the string/keyword changes. |
|
Whoops, I meant to do this to the corresponding issue, my bad. |
Fixes #6409
This is a WIP to update all of the
stringfield mappings in Kibana to eithertextorkeyword, whichever is most appropriate for each field. In cases where I have some doubt about whethertextorkeywordis most appropriate I'm leaning towardstextsince it's matches the basicstringdefinition we were previously using.I've got things fixed up to a point where I can start up and use Kibana without getting any errors. Now I'm working on updating the functional tests and functional test fixtures, but I'm currently blocked by this bug: elastic/elasticsearch#16945