[7.x] [Reporting] Improve functional test steps (#63259)#63519
[7.x] [Reporting] Improve functional test steps (#63259)#63519tsullivan merged 5 commits intoelastic:7.xfrom
Conversation
bc6dd5e to
d668da3
Compare
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
These changes bring the 7.x branch in sync with master for this file.
There was a problem hiding this comment.
note: getUrl returns a relative URL
There was a problem hiding this comment.
Note: relative URL is returned
There was a problem hiding this comment.
Note: This file's changes are from being copied from master
93f6d7a to
d668da3
Compare
| ); | ||
| expect(percentSimilar).to.be.lessThan(0.05); | ||
| const url = await PageObjects.reporting.getReportURL(60000); | ||
| expect(url).to.match(/download/); |
There was a problem hiding this comment.
@joelgriffith I found that I was not able to use the same code here as there is in master, where we're actually sending a request out for the URL and checking response headers for OK values. In this branch, the url value returned is relative, so the fetch was failing since it didn't have the correct host or port number.
There aren't very many code differences between 7.x and master in this branch, so I'm not sure what the difference is that is making the return URL something that can't be requested. That's why this just does a regex match on the returned URL string.
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Backports the following commits to 7.x: