Skip to content

[7.x] Mark rule run as failure if there was an error (#62383)#62513

Merged
rylnd merged 1 commit intoelastic:7.xfrom
rylnd:backport/7.x/pr-62383
Apr 3, 2020
Merged

[7.x] Mark rule run as failure if there was an error (#62383)#62513
rylnd merged 1 commit intoelastic:7.xfrom
rylnd:backport/7.x/pr-62383

Conversation

@rylnd
Copy link
Copy Markdown
Contributor

@rylnd rylnd commented Apr 3, 2020

Backports the following commits to 7.x:

@rylnd
Mark rule run as failure if there was an error (elastic#62383)
c35448d 
While we still let the rule execute in the case of gap errors and
stopped ML jobs, we now mark that execution as a failure instead of a
success.
@rylnd rylnd added the backport This PR is a backport of another PR label Apr 3, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 3, 2020

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-xpack-agent / Closes and opens signals.Detections Closing signals Closes and opens signals

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 17 times on tracked branches: https://github.com/elastic/kibana/issues/61132

Stack Trace

CypressError: Timed out retrying: expected '0' to equal '105'
    at cypressErr (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:138644:9)
    at throwErr (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:138577:11)
    at Object.throwErrByPath (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:138625:3)
    at retry (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:132905:19)
    at onFailFn (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:121122:16)
    at tryCatcher (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:165465:23)
    at Promise._settlePromiseFromHandler (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:163401:31)
    at Promise._settlePromise (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:163458:18)
    at Promise._settlePromise0 (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:163503:10)
    at Promise._settlePromises (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:163578:18)
    at Async../node_modules/bluebird/js/release/async.js.Async._drainQueue (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:160190:16)
    at Async../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:160200:10)
    at Async.drainQueues (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:160074:14)

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd added the release_note:skip Skip the PR/issue when compiling release notes label Apr 3, 2020
@rylnd rylnd merged commit d42c08f into elastic:7.x Apr 3, 2020
@rylnd rylnd deleted the backport/7.x/pr-62383 branch April 3, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR release_note:skip Skip the PR/issue when compiling release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rylnd @kibanamachine