[Logs UI] Cleanup /log_entries/entries's underlying implementation#60764
Merged
afgomez merged 4 commits intoelastic:masterfrom Mar 26, 2020
Merged
[Logs UI] Cleanup /log_entries/entries's underlying implementation#60764afgomez merged 4 commits intoelastic:masterfrom
/log_entries/entries's underlying implementation#60764afgomez merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
3 tasks
aa4bfa8 to
45799eb
Compare
weltenwort
approved these changes
Mar 25, 2020
Member
weltenwort
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning it up 👍
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #59875. Cleanup some of the implementation details in the domain and adapters for log entries.