Change APM OSS plugin name from apm_oss to apmOss by mohinderps · Pull Request #60379 · elastic/kibana

mohinderps · 2020-03-17T14:46:07Z

Summary

Snake case plugin names give warning in console. In this PR, APM OSS plugin's name is changed fro apm_oss to apmOss

kibanamachine · 2020-03-17T14:46:09Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine · 2020-03-17T14:57:07Z

Pinging @elastic/apm-ui (Team:apm)

smith · 2020-03-17T20:19:35Z

@elasticmachine test this please

smith

Thanks for doing this! 👍 assuming tests pass.

smith · 2020-03-19T00:40:37Z

retest

sorenlouv · 2020-03-19T07:47:58Z

retest

mohinderps · 2020-03-19T08:20:12Z

Hi @sqren, what has happened here ? Is there anything I need to do here ?

sorenlouv · 2020-03-19T10:24:37Z

@elasticmachine merge upstream

sorenlouv · 2020-03-19T10:25:00Z

Hi @sqren, what has happened here ? Is there anything I need to do here ?

Just the build acting up. I'll kick it.

mohinderps · 2020-03-19T10:39:38Z

Hi @sqren, what has happened here ? Is there anything I need to do here ?

Just the build acting up. I'll kick it.

Cool!

sorenlouv · 2020-03-19T11:15:22Z

retest

sorenlouv · 2020-03-19T16:29:44Z

retest

sorenlouv · 2020-03-19T16:32:36Z

retest

sorenlouv · 2020-03-22T21:54:55Z

@elasticmachine merge upstream

sorenlouv · 2020-03-22T21:56:17Z

retest

smith · 2020-03-23T01:25:27Z

retest

sorenlouv · 2020-03-23T10:09:52Z

x-pack/plugins/apm/kibana.json

I think the build is failing because the following two instances of apm_oss also need to be changed:

kibana/x-pack/plugins/apm/server/plugin.ts

Line 45 in 7bafeb1

apm_oss: APMOSSPluginSetup;

to:

apmOss: APMOSSPluginSetup;

and...

kibana/x-pack/plugins/apm/server/plugin.ts

Line 54 in 7bafeb1

const mergedConfig$ = combineLatest(plugins.apm_oss.config$, config$).pipe(

to:

const mergedConfig$ = combineLatest(plugins.apmOss.config$, config$).pipe(

@joshdover do you agree?

@sqren I think you're right. This is happening on startup for me:

server log [08:08:06.407] [fatal][root] TypeError: Cannot read property 'config$' of undefined at APMPlugin.setup (/Users/smith/Code/kibana/x-pack/plugins/apm/server/plugin.ts:54:57) at PluginWrapper.setup (/Users/smith/Code/kibana/src/core/server/plugins/plugin.ts:100:26) at PluginsSystem.setupPlugins (/Users/smith/Code/kibana/src/core/server/plugins/plugins_system.ts:91:25) at process._tickCallback (internal/process/next_tick.js:68:7)

Oh! I can do that.

Yes that sounds right

smith · 2020-03-25T18:40:24Z

retest

smith · 2020-03-25T23:49:43Z

@elasticmachine test this please

kibanamachine · 2020-03-26T01:47:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 0b86fe8
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

History

💔 Build #35273 failed ce04aceceaba7f9b142ec24d0c46427872b682af
💔 Build #35258 failed ce04aceceaba7f9b142ec24d0c46427872b682af
💔 Build #34477 failed 7e43a69a701e230d1ec41c1d895f92eb6e65acb9
💔 Build #34432 failed 1355acd
💔 Build #34395 failed 1355acd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

smith

Looks like this is failing with:

 FATAL  TypeError: Cannot read property 'registerLegacyAPI' of undefined

which I think is happening here:

kibana/x-pack/legacy/plugins/apm/index.ts

Line 140 in 9243b6d

apmPlugin.registerLegacyAPI({

I haven't gotten a chance to figure out what's causing that though.

smith · 2020-03-27T19:19:15Z

Tagging this as 7.8.

mohinderps · 2020-03-30T04:55:02Z

Looks like this is failing with:
 FATAL  TypeError: Cannot read property 'registerLegacyAPI' of undefined
which I think is happening here:

kibana/x-pack/legacy/plugins/apm/index.ts

Line 140 in 9243b6d

apmPlugin.registerLegacyAPI({

I haven't gotten a chance to figure out what's causing that though.

Looking into this.

ogupte · 2020-04-22T14:46:51Z

@mohinderps Let me know if you need any help looking in to this.

mohinderps · 2020-04-23T04:51:05Z

@mohinderps Let me know if you need any help looking in to t

@mohinderps Let me know if you need any help looking in to this.

Yes please. I have no idea why apmPlugin is undefined as @smith says.

ogupte · 2020-05-12T23:37:34Z

@mohinderps I was able to get the CI tests to pass in another branch and also updated the plugin name in the apm dependencies in this PR: #66164. Thank you for the contribution!

mohinderps requested a review from a team March 17, 2020 14:46

timroes added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Mar 17, 2020

smith added v7.7.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 17, 2020

smith approved these changes Mar 17, 2020

View reviewed changes

sorenlouv approved these changes Mar 18, 2020

View reviewed changes

sorenlouv reviewed Mar 23, 2020

View reviewed changes

kibanamachine added the 💝community label Mar 23, 2020

mohinderps added 2 commits March 24, 2020 22:41

Change apm oss plugin name from apm_oss to apmOss

b2c920a

change plugin name

0b86fe8

mohinderps force-pushed the change-plugin-name-apm_oss branch from ce04ace to 0b86fe8 Compare March 24, 2020 17:14

smith self-requested a review March 26, 2020 02:43

smith requested changes Mar 26, 2020

View reviewed changes

smith added v7.8.0 and removed v7.7.0 labels Mar 27, 2020

ogupte mentioned this pull request May 12, 2020

[APM] Change plugin id for apm_oss to apmOss #66164

Merged

ogupte closed this May 12, 2020

Conversation

mohinderps commented Mar 17, 2020

Uh oh!

kibanamachine commented Mar 17, 2020

Uh oh!

elasticmachine commented Mar 17, 2020

Uh oh!

smith commented Mar 17, 2020

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

smith commented Mar 19, 2020

Uh oh!

sorenlouv commented Mar 19, 2020

Uh oh!

mohinderps commented Mar 19, 2020

Uh oh!

sorenlouv commented Mar 19, 2020

Uh oh!

sorenlouv commented Mar 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mohinderps commented Mar 19, 2020

Uh oh!

sorenlouv commented Mar 19, 2020

Uh oh!

sorenlouv commented Mar 19, 2020

Uh oh!

sorenlouv commented Mar 19, 2020

Uh oh!

sorenlouv commented Mar 22, 2020

Uh oh!

sorenlouv commented Mar 22, 2020

Uh oh!

smith commented Mar 23, 2020

Uh oh!

sorenlouv Mar 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smith Mar 23, 2020

Choose a reason for hiding this comment

Uh oh!

mohinderps Mar 23, 2020

Choose a reason for hiding this comment

Uh oh!

joshdover Mar 23, 2020

Choose a reason for hiding this comment

Uh oh!

smith commented Mar 25, 2020

Uh oh!

smith commented Mar 25, 2020

Uh oh!

kibanamachine commented Mar 26, 2020

💔 Build Failed

Failed CI Steps

History

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

smith commented Mar 27, 2020

Uh oh!

mohinderps commented Mar 30, 2020

Uh oh!

ogupte commented Apr 22, 2020

Uh oh!

mohinderps commented Apr 23, 2020

Uh oh!

ogupte commented May 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

sorenlouv commented Mar 19, 2020 •

edited

Loading

sorenlouv Mar 23, 2020 •

edited

Loading