[7.6] [TSVB] fix text color when using custom background color (#60261) by markov00 · Pull Request #60365 · elastic/kibana

markov00 · 2020-03-17T11:43:47Z

Backports the following commits to 7.6:

[TSVB] fix text color when using custom background color ([TSVB] fix text color when using custom background color #60261)

When the user apply a background color manually from the UI, this commit adapt the current colors to have a better contrast with the chosen background color irrespective of the used dark/light theme

kibanamachine · 2020-03-17T13:09:15Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 517d5ef
Flaky suites:
- kibana-ciGroup1

Test Failures

Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/context/_date_nanos·js.context app context view for date_nanos displays correctly when predecessors and successors are loaded

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/58760

[00:00:00]       │
[00:00:12]         └-: context app
[00:00:12]           └-> "before all" hook
[00:00:12]           └-> "before all" hook
[00:00:12]             │ info [logstash_functional] Loading "mappings.json"
[00:00:12]             │ info [logstash_functional] Loading "data.json.gz"
[00:00:12]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:12]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.22][0]]]).
[00:00:12]             │ info [logstash_functional] Created index "logstash-2015.09.22"
[00:00:12]             │ debg [logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:12]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:12]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.20][0]]]).
[00:00:12]             │ info [logstash_functional] Created index "logstash-2015.09.20"
[00:00:12]             │ debg [logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:12]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:12]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.21][0]]]).
[00:00:12]             │ info [logstash_functional] Created index "logstash-2015.09.21"
[00:00:12]             │ debg [logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:22]             │ info progress: 12638
[00:00:23]             │ info [visualize] Loading "mappings.json"
[00:00:23]             │ info [visualize] Loading "data.json"
[00:00:23]             │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana_1/wKSgR7RkS8SRx43NpkIpeQ] deleting index
[00:00:23]             │ info [visualize] Deleted existing index [".kibana_1"]
[00:00:23]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:23]             │ info [visualize] Created index ".kibana"
[00:00:23]             │ debg [visualize] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:00:23]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana/eoSJa_WiT-mFk0BjHneSvw] update_mapping [_doc]
[00:00:30]             │ info Creating index .kibana_2.
[00:00:30]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:30]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] updating number_of_replicas to [0] for indices [.kibana_2]
[00:00:30]             │ info Reindexing .kibana to .kibana_1
[00:00:30]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:30]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] updating number_of_replicas to [0] for indices [.kibana_1]
[00:00:30]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.tasks] creating index, cause [auto(task api)], templates [], shards [1]/[1], mappings [task]
[00:00:30]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] updating number_of_replicas to [0] for indices [.tasks]
[00:00:30]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] 866 finished with response BulkByScrollResponse[took=73.2ms,timed_out=false,sliceId=null,updated=0,created=7,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:00:31]             │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana/eoSJa_WiT-mFk0BjHneSvw] deleting index
[00:00:31]             │ info Migrating .kibana_1 saved objects to .kibana_2
[00:00:31]             │ debg Migrating saved objects index-pattern:logstash-*, index-pattern:logstash*, index-pattern:long-window-logstash-*, visualization:Shared-Item-Visualization-AreaChart, visualization:68305470-87bc-11e9-a991-3b492a7c3e09, visualization:64983230-87bf-11e9-a991-3b492a7c3e09, visualization:5d2de430-87c0-11e9-a991-3b492a7c3e09
[00:00:31]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana_2/_1HUcBjpTnWXKibSLzTD4w] update_mapping [_doc]
[00:00:31]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana_2/_1HUcBjpTnWXKibSLzTD4w] update_mapping [_doc]
[00:00:31]             │ info Pointing alias .kibana to .kibana_2.
[00:00:31]             │ info Finished in 619ms.
[00:00:31]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","telemetry:optIn":false}
[00:00:31]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana_2/_1HUcBjpTnWXKibSLzTD4w] update_mapping [_doc]
[00:00:32]             │ debg replacing kibana config doc: {"defaultIndex":"logstash-*"}
[00:00:32]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana_2/_1HUcBjpTnWXKibSLzTD4w] update_mapping [_doc]
[00:00:33]             │ debg navigating to discover url: http://localhost:6121/app/kibana#/discover
[00:00:33]             │ debg Navigate to: http://localhost:6121/app/kibana#/discover
[00:00:33]             │ debg ... sleep(700) start
[00:00:33]             │ debg browser[INFO] http://localhost:6121/app/kibana?_t=1584446434353#/discover 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:33]             │
[00:00:33]             │ debg browser[INFO] http://localhost:6121/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:34]             │ debg ... sleep(700) end
[00:00:34]             │ debg returned from get, calling refresh
[00:00:34]             │ debg currentUrl = http://localhost:6121/app/kibana#/discover
[00:00:34]             │          appUrl = http://localhost:6121/app/kibana#/discover
[00:00:34]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:36]             │ debg TestSubjects.find(kibanaChrome)
[00:00:36]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:00:36]             │ debg browser[INFO] http://localhost:6121/app/kibana?_t=1584446434353#/discover 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:36]             │
[00:00:36]             │ debg browser[INFO] http://localhost:6121/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:36]             │ debg browser[INFO] http://localhost:6121/built_assets/dlls/vendors_2.bundle.dll.js 36:140950 "INFO: 2020-03-17T12:00:37Z
[00:00:36]             │        Adding connection to http://localhost:6121/elasticsearch
[00:00:36]             │
[00:00:36]             │      "
[00:00:36]             │ debg ... sleep(501) start
[00:00:37]             │ debg ... sleep(501) end
[00:00:37]             │ debg in navigateTo url = http://localhost:6121/app/kibana#/discover?_g=()
[00:00:37]             │ debg TestSubjects.exists(statusPageContainer)
[00:00:37]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:00:39]             │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:03:07]           └-: context view for date_nanos
[00:03:07]             └-> "before all" hook
[00:03:07]             └-> "before all" hook
[00:03:07]               │ info [date_nanos] Loading "mappings.json"
[00:03:07]               │ info [date_nanos] Loading "data.json"
[00:03:07]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [date-nanos] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:03:07]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[date-nanos][0]]]).
[00:03:07]               │ info [date_nanos] Created index "date-nanos"
[00:03:07]               │ debg [date_nanos] "date-nanos" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:03:07]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [date-nanos/V8NyiiNtQYaDfD_tW_ao4A] update_mapping [_doc]
[00:03:07]               │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:03:07]               │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:03:08]               │ info Creating index .kibana_3.
[00:03:08]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana_3] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:03:08]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] updating number_of_replicas to [0] for indices [.kibana_3]
[00:03:08]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_3][0]]]).
[00:03:08]               │ info Migrating .kibana_2 saved objects to .kibana_3
[00:03:08]               │ debg Migrating saved objects index-pattern:logstash*, index-pattern:long-window-logstash-*, visualization:Shared-Item-Visualization-AreaChart, visualization:68305470-87bc-11e9-a991-3b492a7c3e09, visualization:64983230-87bf-11e9-a991-3b492a7c3e09, visualization:5d2de430-87c0-11e9-a991-3b492a7c3e09, index-pattern:logstash-*, config:7.6.2-SNAPSHOT, index-pattern:date-nanos, search:ab12e3c0-f231-11e6-9486-733b1ac9221a
[00:03:08]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana_3/YDMF747yTv2Fz1w76H47Cw] update_mapping [_doc]
[00:03:08]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana_3/YDMF747yTv2Fz1w76H47Cw] update_mapping [_doc]
[00:03:08]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana_3/YDMF747yTv2Fz1w76H47Cw] update_mapping [_doc]
[00:03:08]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584445458313553844] [.kibana_3/YDMF747yTv2Fz1w76H47Cw] update_mapping [_doc]
[00:03:08]               │ info Pointing alias .kibana to .kibana_3.
[00:03:08]               │ info Finished in 281ms.
[00:03:08]               │ debg replacing kibana config doc: {"defaultIndex":"date-nanos"}
[00:03:09]               │ debg applying update to kibana config: {"context:defaultSize":"1","context:step":"3"}
[00:03:10]               │ debg --- retry.try failed again with the same message...
[00:03:10]             └-> displays predessors - anchor - successors in right order 
[00:03:10]               └-> "before each" hook: global before each
[00:03:10]               │ debg browser.get(http://localhost:6121/app/kibana#/context/date-nanos/AU_x3-TaGFA8no6Qj999Z?_a=(columns:!('@message')))
[00:03:10]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:03:10]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:03:10]               │ debg browser[INFO] http://localhost:6121/app/kibana?_t=1584446591117#/context/date-nanos/AU_x3-TaGFA8no6Qj999Z?_a=(columns:!(%27@message%27)) 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:10]               │
[00:03:10]               │ debg browser[INFO] http://localhost:6121/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:10]               │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:03:10]               │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:03:14]               │ debg browser[INFO] http://localhost:6121/built_assets/dlls/vendors_2.bundle.dll.js 36:140950 "INFO: 2020-03-17T12:03:14Z
[00:03:14]               │        Adding connection to http://localhost:6121/elasticsearch
[00:03:14]               │
[00:03:14]               │      "
[00:03:14]               │ debg TestSubjects.find(successorsLoadMoreButton)
[00:03:14]               │ debg Find.findByCssSelector('[data-test-subj="successorsLoadMoreButton"]') with timeout=10000
[00:03:24]               │ debg --- retry.try failed again with the same message...
[00:03:24]               │ debg TestSubjects.find(predecessorsLoadMoreButton)
[00:03:24]               │ debg Find.findByCssSelector('[data-test-subj="predecessorsLoadMoreButton"]') with timeout=10000
[00:03:24]               │ debg ... sleep(1000) start
[00:03:24]               │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:03:24]               │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:03:25]               │ debg ... sleep(1000) end
[00:03:25]               │ debg TestSubjects.find(docTable)
[00:03:25]               │ debg Find.findByCssSelector('[data-test-subj="docTable"]') with timeout=10000
[00:03:27]               │ debg --- retry.try failed again with the same message...
[00:03:27]               └- ✓ pass  (16.7s) "context app context view for date_nanos displays predessors - anchor - successors in right order "
[00:03:27]             └-> displays correctly when predecessors and successors are loaded
[00:03:27]               └-> "before each" hook: global before each
[00:03:27]               │ debg browser.get(http://localhost:6121/app/kibana#/context/date-nanos/AU_x3-TaGFA8no6Qjisd?_a=(columns:!('@message')))
[00:03:27]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:03:27]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:03:27]               │ debg browser[INFO] http://localhost:6121/app/kibana?_t=1584446607771#/context/date-nanos/AU_x3-TaGFA8no6Qjisd?_a=(columns:!(%27@message%27)) 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:27]               │
[00:03:27]               │ debg browser[INFO] http://localhost:6121/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:27]               │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:03:27]               │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:03:30]               │ debg browser[INFO] http://localhost:6121/built_assets/dlls/vendors_2.bundle.dll.js 36:140950 "INFO: 2020-03-17T12:03:30Z
[00:03:30]               │        Adding connection to http://localhost:6121/elasticsearch
[00:03:30]               │
[00:03:30]               │      "
[00:03:30]               │ debg TestSubjects.find(successorsLoadMoreButton)
[00:03:30]               │ debg Find.findByCssSelector('[data-test-subj="successorsLoadMoreButton"]') with timeout=10000
[00:03:40]               │ debg --- retry.try failed again with the same message...
[00:03:40]               │ debg TestSubjects.find(predecessorsLoadMoreButton)
[00:03:40]               │ debg Find.findByCssSelector('[data-test-subj="predecessorsLoadMoreButton"]') with timeout=10000
[00:03:40]               │ debg ... sleep(1000) start
[00:03:40]               └- ✖ fail: "context app context view for date_nanos displays correctly when predecessors and successors are loaded"
[00:03:40]               │

Stack Trace

{ DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    at emitDeprecationWarning (internal/process/promises.js:111:13)
    at emitWarning (internal/process/promises.js:104:3)
    at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
    at process._tickCallback (internal/process/next_tick.js:69:34) name: 'DeprecationWarning', code: 'DEP0018', uncaught: true }

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[TSVB] fix text color when using custom background color (elastic#60261)

517d5ef

When the user apply a background color manually from the UI, this commit adapt the current colors to have a better contrast with the chosen background color irrespective of the used dark/light theme

markov00 added the backport This PR is a backport of another PR label Mar 17, 2020

markov00 merged commit cb7838d into elastic:7.6 Mar 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[7.6] [TSVB] fix text color when using custom background color (#60261)#60365

[7.6] [TSVB] fix text color when using custom background color (#60261)#60365
markov00 merged 1 commit intoelastic:7.6from
markov00:backport/7.6/pr-60261

markov00 commented Mar 17, 2020

Uh oh!

kibanamachine commented Mar 17, 2020

Standard Out

Stack Trace

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

markov00 commented Mar 17, 2020

Uh oh!

kibanamachine commented Mar 17, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants