POC - Export query-string as @kbn/query-string#58948
Closed
lukeelmers wants to merge 1 commit intoelastic:masterfrom
Closed
POC - Export query-string as @kbn/query-string#58948lukeelmers wants to merge 1 commit intoelastic:masterfrom
query-string as @kbn/query-string#58948lukeelmers wants to merge 1 commit intoelastic:masterfrom
Conversation
cd5b9c4 to
de3d442
Compare
Fixes elastic#58684. In elastic#56957 we consolidated usage of various query string utils by using the `query-string` dependency everywhere. Unfortunately, this introduced a regression where Kibana failed in IE11 due to dropped IE support as of `query-string` v6.0.0. Downgrading is not an easy option due to changed APIs and lack of type definitions. This POC experiments with the idea of requiring the original `query-string` package, copying the files into this package, and running them through babel. As a result, plugins can use `@kbn/query-string` as a drop-in replacement for `query-string`, the only difference being that the upstream library has now been transpiled.
de3d442 to
968afe9
Compare
7 tasks
Contributor
💔 Build FailedTo update your PR or re-run it, just comment with: |
Contributor
Author
|
Closing in favor of #58943 |
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #58684.
In #56957 we consolidated usage of various query string utils by using
the
query-stringdependency everywhere. Unfortunately, this introduceda regression where Kibana failed in IE11 due to dropped IE support as of
query-stringv6.0.0. Downgrading is not an easy option due to changedAPIs and lack of type definitions.
One proposed solution was brought up in #58771, but we received feedback
that ops has put a hard stop to transpiling node_modules.
This POC experiments with the idea of requiring the original
query-stringpackage, copying the files into a kibana package, and runningthem through babel so that everything is built during
kbn bootstrap.As a result, plugins can use
@kbn/query-stringas a drop-inreplacement for
query-string, the only difference being that theupstream library has now been transpiled by the shell package.