Skip to content

[7.x] Improve action and trigger types (#58657)#58909

Merged
stacey-gammon merged 1 commit intoelastic:7.xfrom
stacey-gammon:backport/7.x/pr-58657
Feb 28, 2020
Merged

[7.x] Improve action and trigger types (#58657)#58909
stacey-gammon merged 1 commit intoelastic:7.xfrom
stacey-gammon:backport/7.x/pr-58657

Conversation

@stacey-gammon
Copy link
Copy Markdown

@stacey-gammon stacey-gammon commented Feb 28, 2020

Backports the following commits to 7.x:

Improve action and trigger types (elastic#58657)
78e3b76 
* Improve types so emitting the wrong context shape complains, as does using a trigger id that has not been added to the trigger context mapping.

* remove unneccessary code
@stacey-gammon stacey-gammon added the backport This PR is a backport of another PR label Feb 28, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 28, 2020

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/timelion/_expression_typeahead·js.timelion app expression typeahead "before all" hook

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 3 times on tracked branches: https://github.com/elastic/kibana/issues/58817

[00:00:00]       │
[00:02:55]         └-: timelion app
[00:02:55]           └-> "before all" hook
[00:02:55]           └-> "before all" hook
[00:02:55]             │ debg Starting timelion before method
[00:02:55]             │ info [logstash_functional] Loading "mappings.json"
[00:02:55]             │ info [logstash_functional] Loading "data.json.gz"
[00:02:55]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:02:55]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.22][0]]]).
[00:02:55]             │ info [logstash_functional] Created index "logstash-2015.09.22"
[00:02:55]             │ debg [logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:02:55]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:02:55]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.20][0]]]).
[00:02:55]             │ info [logstash_functional] Created index "logstash-2015.09.20"
[00:02:55]             │ debg [logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:02:55]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:02:55]             │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:02:55]             │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:02:55]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.21][0]]]).
[00:02:55]             │ info [logstash_functional] Created index "logstash-2015.09.21"
[00:02:55]             │ debg [logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:02:58]             │ debg --- retry.try failed again with the same message...
[00:02:58]             │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:02:58]             │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:03:01]             │ debg --- retry.try failed again with the same message...
[00:03:01]             │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:03:01]             │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:03:04]             │ debg --- retry.try failed again with the same message...
[00:03:04]             │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:03:04]             │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:03:05]             │ info progress: 12641
[00:03:06]             │ info [logstash_functional] Indexed 4633 docs into "logstash-2015.09.22"
[00:03:06]             │ info [logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:03:06]             │ info [logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:03:06]             │ debg replacing kibana config doc: {"defaultIndex":"logstash-*"}
[00:03:07]             │ debg --- retry.try failed again with the same message...
[00:03:07]             │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:03:07]             │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:03:07]           └-: expression typeahead
[00:03:07]             └-> "before all" hook
[00:03:10]               │ debg --- retry.try failed again with the same message...
[00:03:10]             └-> "before all" hook
[00:03:10]               │ debg replacing kibana config doc: {"defaultIndex":"logstash-*"}
[00:03:10]               │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:03:10]               │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:03:10]               │ debg load kibana index
[00:03:10]               │ info [timelion] Loading "mappings.json"
[00:03:10]               │ info [timelion] Loading "data.json.gz"
[00:03:11]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] [.kibana_2/v0_EncxOTna8VbmrZw7YLQ] deleting index
[00:03:11]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] [.kibana_1/CtStyRJrQY2r-SyVMD5svg] deleting index
[00:03:11]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] [.kibana_3/O2ITfYIYSIe6-VEG38gLwA] deleting index
[00:03:11]               │ info [timelion] Deleted existing index [".kibana_2",".kibana_1",".kibana_3"]
[00:03:11]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:03:11]               │ info [timelion] Created index ".kibana"
[00:03:11]               │ debg [timelion] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:03:11]               │ info [timelion] Indexed 1 docs into ".kibana"
[00:03:11]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] [.kibana/P-S2plznSzaNKlvU_kOazQ] update_mapping [_doc]
[00:03:11]               │ debg Migrating saved objects
[00:03:11]               │ proc [kibana]   log   [17:35:44.452] [info][savedobjects-service] Creating index .kibana_2.
[00:03:11]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:03:11]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] updating number_of_replicas to [0] for indices [.kibana_2]
[00:03:11]               │ proc [kibana]   log   [17:35:44.535] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:03:11]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:03:11]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] updating number_of_replicas to [0] for indices [.kibana_1]
[00:03:11]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] 2474 finished with response BulkByScrollResponse[took=39.4ms,timed_out=false,sliceId=null,updated=0,created=1,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:03:11]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] [.kibana/P-S2plznSzaNKlvU_kOazQ] deleting index
[00:03:11]               │ proc [kibana]   log   [17:35:44.917] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:03:11]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] [.kibana_2/sZ0k82v0TMqE1XyxUfzEfA] update_mapping [_doc]
[00:03:11]               │ proc [kibana]   log   [17:35:45.000] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:03:11]               │ proc [kibana]   log   [17:35:45.063] [info][savedobjects-service] Finished in 613ms.
[00:03:11]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:03:12]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1582909992212331018] [.kibana_2/sZ0k82v0TMqE1XyxUfzEfA] update_mapping [_doc]
[00:03:13]               │ debg navigating to timelion url: http://localhost:6111/app/timelion
[00:03:13]               │ debg Navigate to: http://localhost:6111/app/timelion
[00:03:13]               │ debg ... sleep(700) start
[00:03:13]               │ debg browser[INFO] http://localhost:6111/app/timelion?_t=1582911346541 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:13]               │
[00:03:13]               │ debg browser[INFO] http://localhost:6111/bundles/app/timelion/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:13]               │ debg --- retry.try failed again with the same message...
[00:03:14]               │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:03:14]               │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:03:14]               │ debg ... sleep(700) end
[00:03:14]               │ debg returned from get, calling refresh
[00:03:16]               │ debg browser[INFO] http://localhost:6111/bundles/plugin/data/data.plugin.js 62:139970 "INFO: 2020-02-28T17:35:48Z
[00:03:16]               │        Adding connection to http://localhost:6111/elasticsearch
[00:03:16]               │
[00:03:16]               │      "
[00:03:16]               │ debg --- retry.try failed again with the same message...
[00:03:16]               │ debg currentUrl = http://localhost:6111/app/timelion#/?_g=()&_a=(columns:2,interval:auto,rows:2,selected:0,sheet:!(%27.es(*)%27))
[00:03:16]               │          appUrl = http://localhost:6111/app/timelion
[00:03:16]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:03:17]               │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:03:17]               │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:03:19]               │ debg browser[INFO] http://localhost:6111/app/timelion?_t=1582911346541#/?_g=()&_a=(columns:2,interval:auto,rows:2,selected:0,sheet:!('.es(*)')) 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:19]               │
[00:03:19]               │ debg browser[INFO] http://localhost:6111/bundles/app/timelion/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:19]               │ debg browser[INFO] http://localhost:6111/bundles/plugin/data/data.plugin.js 62:139970 "INFO: 2020-02-28T17:35:51Z
[00:03:19]               │        Adding connection to http://localhost:6111/elasticsearch
[00:03:19]               │
[00:03:19]               │      "
[00:03:19]               │ debg ... sleep(501) start
[00:03:19]               │ debg ... sleep(501) end
[00:03:21]               │ debg in navigateTo url = http://localhost:6111/app/timelion#/?_g=()&_a=(columns:2,interval:auto,rows:2,selected:0,sheet:!(%27.es(*)%27))
[00:03:21]               │ debg TestSubjects.exists(statusPageContainer)
[00:03:21]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:03:21]               │ debg --- retry.try failed again with the same message...
[00:03:22]               │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:03:22]               │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:03:26]               │ debg --- retry.try failed again with the same message...
[00:03:26]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:03:27]               │ debg TestSubjects.exists(filter filter-disabled filter-key-geo.src filter-value-IN)
[00:03:27]               │ debg Find.existsByCssSelector('[data-test-subj="filter filter-disabled filter-key-geo.src filter-value-IN"]') with timeout=2500
[00:03:29]               │ debg --- retry.try failed again with the same message...
[00:03:29]               │ debg Setting absolute range to Sep 19, 2015 @ 06:31:44.000 to Sep 23, 2015 @ 18:31:44.000
[00:03:29]               │ debg TestSubjects.exists(superDatePickerToggleQuickMenuButton)
[00:03:29]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=20000
[00:03:29]               │ debg TestSubjects.exists(superDatePickerShowDatesButton)
[00:03:29]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=2500
[00:03:29]               │ debg TestSubjects.click(superDatePickerShowDatesButton)
[00:03:29]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:03:29]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:03:30]               │ debg TestSubjects.exists(superDatePickerstartDatePopoverButton)
[00:03:30]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=2500
[00:03:30]               │ debg TestSubjects.click(superDatePickerendDatePopoverButton)
[00:03:30]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:03:30]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:03:30]               │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:03:30]               └- ✖ fail: "timelion app expression typeahead "before all" hook"
[00:03:30]               │

Stack Trace

{ DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    at emitDeprecationWarning (internal/process/promises.js:111:13)
    at emitWarning (internal/process/promises.js:104:3)
    at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
    at process._tickCallback (internal/process/next_tick.js:69:34) name: 'DeprecationWarning', code: 'DEP0018', uncaught: true }

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stacey-gammon stacey-gammon merged commit f0eaad0 into elastic:7.x Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stacey-gammon @kibanamachine