Skip to content

[7.x] Prevent core savedObjects plugin from being overridden (#58193)#58194

Merged
rylnd merged 2 commits intoelastic:7.xfrom
rylnd:backport/7.x/pr-58193
Feb 21, 2020
Merged

[7.x] Prevent core savedObjects plugin from being overridden (#58193)#58194
rylnd merged 2 commits intoelastic:7.xfrom
rylnd:backport/7.x/pr-58193

Conversation

@rylnd
Copy link
Copy Markdown
Contributor

@rylnd rylnd commented Feb 21, 2020

Backports the following commits to 7.x:

PR elastic#57452 added an empty savedObjects plugin with the same name as the
core plugin. Due to the way we were spreading into our context coupled
with the fact that we don't get NP's whitelisting of plugins on legacy,
we were overriding the core plugin here.

If this happens again, we should perhaps whitelist our plugins here.
@rylnd rylnd added the backport This PR is a backport of another PR label Feb 21, 2020
@rylnd
Copy link
Copy Markdown
Contributor Author

rylnd commented Feb 21, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd merged commit 64215c5 into elastic:7.x Feb 21, 2020
@rylnd rylnd deleted the backport/7.x/pr-58193 branch February 21, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants