[Maps] Update GisMapController to use stateful SearchBar#57282
Closed
nreese wants to merge 6 commits intoelastic:masterfrom
Closed
[Maps] Update GisMapController to use stateful SearchBar#57282nreese wants to merge 6 commits intoelastic:masterfrom
nreese wants to merge 6 commits intoelastic:masterfrom
Conversation
lizozom
reviewed
Feb 11, 2020
| show-filter-bar="chrome.getVisible()" | ||
| show-date-picker="showDatePicker" | ||
| show-save-query="showSaveQuery" | ||
| index-patterns="indexPatterns" |
lizozom
reviewed
Feb 11, 2020
|
|
||
| function syncAppAndGlobalState() { | ||
| const onQueryChange = _.debounce((forceRefresh = false) => { | ||
| console.log('onQueryChange'); |
lizozom
reviewed
Feb 11, 2020
| syncAppAndGlobalState(); | ||
|
|
||
| store.dispatch(setRefreshConfig($scope.refreshConfig)); | ||
| $scope.onQuerySubmit = function({ query }) { |
Contributor
There was a problem hiding this comment.
onQuerySubmit has a second, isUpdate argument
lizozom
approved these changes
Feb 11, 2020
Contributor
lizozom
left a comment
There was a problem hiding this comment.
Looks great in terms of using the stateful SearchBar :)
Didn't dive deep into the state management on the app side.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build FailedTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/es_geo_grid_source·js.maps app layer geo grid aggregation source heatmap should re-fetch geotile_grid aggregation with refresh timerStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/es_geo_grid_source·js.maps app layer geo grid aggregation source heatmap should re-fetch geotile_grid aggregation with refresh timerStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/documents_source/search_hits·js.maps app documents source search hits should re-fetch documents with refresh timerStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
kindsun
reviewed
Feb 13, 2020
| } | ||
|
|
||
| async getGeoJsonWithMeta(layerName, searchFilters, registerCancelCallback) { | ||
| console.log('fetch getGeoJsonWithMeta', searchFilters); |
Contributor
Author
|
closing. Obsolete with move to new platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#56160 added
use-default-behaviorstoSearchBarcomponent. This PR updatesGisMapControllerto use this new behavior to simplify $scope and state manegement. This is will make the migration away fromappStateeasier since it removes lots of the state management fromGisMapController