Skip to content

[7.x] Implement UI for Create Alert form (#55232)#57000

Merged
YulNaumenko merged 1 commit intoelastic:7.xfrom
YulNaumenko:backport/7.x/pr-55232
Feb 6, 2020
Merged

[7.x] Implement UI for Create Alert form (#55232)#57000
YulNaumenko merged 1 commit intoelastic:7.xfrom
YulNaumenko:backport/7.x/pr-55232

Conversation

@YulNaumenko
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* Updated Alert ui model, fixed form validation and small issues

* Fixed error messages and validation for action params forms

* Fixed typecheck error

* Moved alert add/edit common fields to alert form

* Fixed type checks

* Refactored alert add flyout by splitting it to the form and flyout components, added some unit tests

* Refactored connector add/edit flyouts and created add connector modal

* Refactored add/edit flyout tests

* Fixed test

* Removed orig files

* Removed orig file

* Added unit tests for add connector modal dialog

* Action Groups idea of implementation

* Removed action group tabs and set only first action group as default (temporary till design will be ready for support multiple groups)

* Added missing unit tests

* Changed design of the email params form

* Fixed actions params forms according to latest mockups

* Fixed options list for available actions connectors

* Fixed modal dialog update on action delete

* fixed build fail

* Added functionality for action types with Message field to Add variables

* Added alertReducer unit tests

* Added create alert functional test

* Added types for Params

* Some design fixes

* alerts empty prompt

* Fixed failing app on save alert and added possibility to hide Change trigger button

* Fixed type check issues

* Added connector config types

* fixed type check

* Fixed merge issues

* Fixed type checks

* Fixed functional tests and error expression message

* Fixed jest tests

* Review changes

Co-authored-by: dave.snider@gmail.com <dave.snider@gmail.com>
@YulNaumenko YulNaumenko added the backport This PR is a backport of another PR label Feb 6, 2020
@mikecote
Copy link
Copy Markdown
Contributor

mikecote commented Feb 6, 2020

Jenkins, test this

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko merged commit 4327eba into elastic:7.x Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants