[Mappings editor] Bring improvements from #55804 PR to master#56282
Merged
sebelga merged 3 commits intoelastic:masterfrom Jan 30, 2020
Merged
[Mappings editor] Bring improvements from #55804 PR to master#56282sebelga merged 3 commits intoelastic:masterfrom
sebelga merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
cjcenizal
approved these changes
Jan 29, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
Code LGTM, didn't test locally.
Contributor
Author
|
Thanks for the review @cjcenizal ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the fix of the Template editor to support mappings types, I made a few improvements to the mappings editor (mainly tests and some small refactor).
This PR brings those improvements from the #55804 PR (targetting
7.x) tomaster.