Skip to content

[7.6] [SIEM] Adds ability to infer the newsfeed.enabled setting (#56236)#56266

Merged
rylnd merged 1 commit intoelastic:7.6from
rylnd:backport/7.6/pr-56236
Jan 29, 2020
Merged

[7.6] [SIEM] Adds ability to infer the newsfeed.enabled setting (#56236)#56266
rylnd merged 1 commit intoelastic:7.6from
rylnd:backport/7.6/pr-56236

Conversation

@rylnd
Copy link
Copy Markdown
Contributor

@rylnd rylnd commented Jan 29, 2020

Backports the following commits to 7.6:

)

* Always return a contract from the newsfeed plugin

Without a contract, dependent plugins have no way of knowing whether the
plugin is enabled or not as the contract will always be undefined.

* Export newsfeed contract types from public index

So that dependent plugins can use them.

* Declare newsfeed as an optional dependency of SIEM

We're going to use the availability of the newsfeed plugin as part of our
determination for whether or not to show the security newsfeed. If users
set `newsfeed.enabled: false`, the plugin will be unavailable and the
security feed will not be shown.

* Respect global newsfeed.enabled config in Security newsfeed

The presence of the newsfeed plugin means that newsfeed.enabled is true.
If both that and our local setting are true, we will show the Security
feed.

* Prefer object type over empty interface

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@rylnd rylnd added the backport This PR is a backport of another PR label Jan 29, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd merged commit 5ec64d5 into elastic:7.6 Jan 29, 2020
@rylnd rylnd deleted the backport/7.6/pr-56236 branch January 29, 2020 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants